i#6662 public traces: allow v2p.textproto in trace dir#7136
Merged
Conversation
Allows the v2p.textproto file to be in the trace directory
of public traces to avoid the following error:
```
$ drrun -t drmemtrace -indir ${path_to_public_trace_dir} -tool invariant_checker
Invalid header
Failed to initialize scheduler: Failed to open <OMITTED>/v2p.textproto
ERROR: failed to initialize analyzer
```
Issue #6662
abhinav92003
requested changes
Dec 15, 2024
also when creating file readers.
abhinav92003
approved these changes
Dec 22, 2024
Merged
edeiana
added a commit
that referenced
this pull request
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the v2p.textproto file to be in the trace directory of public traces
to avoid the following error:
Issue #6662