Skip to content

Conversation

@bouweandela
Copy link
Member

@bouweandela bouweandela commented Nov 26, 2025

Description

Move the esmvalcore.local and esmvalcore.esgf modules into the esmvalcore.io module so we have all data sources in one place.

  • Importing esmvalcore.local is deprecated and will be removed in v2.16. It can be imported as esmvalcore.io.local instead.
  • Importing esmvalcore.esgf is deprecated and will be removed in v2.16. It can be imported as esmvalcore.io.esgf instead.

Links to documentation:

Closes #2882


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.57%. Comparing base (5a317f5) to head (afc9b1b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2911      +/-   ##
==========================================
+ Coverage   95.55%   95.57%   +0.02%     
==========================================
  Files         263      266       +3     
  Lines       15506    15520      +14     
==========================================
+ Hits        14817    14834      +17     
+ Misses        689      686       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela bouweandela marked this pull request as ready for review November 26, 2025 13:37
@bouweandela bouweandela added this to the v2.14.0 milestone Nov 26, 2025
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much appreciated, bud 🍺

@bouweandela
Copy link
Member Author

Thanks for reviewing V!

@bouweandela bouweandela merged commit b8c10a8 into main Nov 27, 2025
4 checks passed
@bouweandela bouweandela deleted the move-local-and-esgf-to-io branch November 27, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move the local and esgf modules from esmvalcore to esmvalcore.io

3 participants