- 
                Notifications
    
You must be signed in to change notification settings  - Fork 17
 
feat: floor price set to the 0.06 USDFC/month #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5062f41    to
    9e3ac3d      
    Compare
  
    | 
           So, Either way is fine tbh. We should pick the easiest route. Maybe the easiest way to do so is setting the min price to 0.57 which is 23.35 GiB, which is also fine....  | 
    
| 
           We can also set 0.5 and be covered againt a slightly smaller basefee max value (at the end of the day we picked the march 2025 avg because there were some oscillation back then, but it is better to come up with a fixed value, I think it won't make a huge difference)  | 
    
9e3ac3d    to
    0cf87b5      
    Compare
  
    | 
           Is it feasible to add a check that the floor price rate is available to be paid when doing   | 
    
| 
           My take away: if it's a minimum from which storage providers are paid as thing as used, this "top up" model is understandable and much better in $ units. I think it's probably better and clearer if it were a larger amount than a couple of cents. $1-5 is not unusual for top-up based usaged pricing models.  | 
    
22e3f0d    to
    0b31223      
    Compare
  
    
          
 Oh, this is a really good idea, and yes it is possible! We have a  See latest commit in here for that feature.  | 
    
0b31223    to
    7e94755      
    Compare
  
    | 
           Does that also cover   | 
    
For storage amounts below ~24.576 GiB, the rate will be 0.06 USDFC / month. Above this amount the price is per-byte. Closes: #319
c9e8ffa    to
    0f671ca      
    Compare
  
    Add comprehensive validation of operator approval settings alongside existing minimum balance check during createDataSet operation. Validates operator is approved with sufficient rate allowance, lockup allowance, and max lockup period.
0f671ca    to
    51efea9      
    Compare
  
    | 
           Figured out how to add additional checks in there. I'm of two minds about this, mostly it's great UX, we catch errors early and can be descriptive about it - good for SPs and good for users. But it also adds complexity and gets FWSS more deeply involved in something that it feels like should be something should be able to ask Filecoin Pay to figure out for us. But it's probably fine. 
  | 
    
          
 We will be able to remove it when we combine   | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
| 
           I'm going to merge it as is, if we want to improve stuff just a bit, let's open a new PR.  | 
    
Edit: This got switched to having 0.06 USDFC as the floor, not the bytes; so now the bytes works out as ~24.576 GiB and we get to talk about it in terms of cents per month.
(PR on top of #316, that should be merged first)
Amounts below this pay as if they are storing 24 GiB, which is 0.05859375 USDFC / month.
Closes: #319
Are we OK with 0.05859375? I have an option here of either setting 24GiB as the floor size or 0.06 as the floor price.
If we go with 0.06 as the floor then we're working with 24.576 GiB floor size.
I also had to change the mock token from 6 decimal places to 18, cause there's already a floor rounding bit of code in here and it was getting stuck on a higher floor due to not enough decimal places, so everything came out wrong.