-
Notifications
You must be signed in to change notification settings - Fork 0
add cnclm51 remapping; provide default "zoom" value for remap_restarts yaml file #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Please add one so that the PR can be merged. |
This PR should go with this PR GEOS-ESM/GEOSgcm_GridComp#1129 |
…ap_params.tpl, remap_utils.py)
…p_lake_landice_saltwater.py)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weiyuan-jiang : I added one commit (4c5441c; please review) and a comment, see below.
…me" (remap_lake_landice_saltwater.py, remap_utils.py)
@weiyuan-jiang last commit, reinstating subroutine fixed the issue. |
@weiyuan-jiang , @biljanaorescanin : I assume you ran into problems because are running GEOSldas with the cnclm51 branch, where get_gridname() is used. I had commented out get_gridname() because it was not used in GEOS_Util. I hadn't realized that it is used in ldas.py of GEOSldas_GridComp. While re-instating get_gridname() in GEOS_Util fixes the issue, I don't think it's the right solution. In ldas.py, get_gridname() is needed for HISTORY pre-processing, which has nothing to do with remap_restarts or GEOS_Util. I think we should move get_gridname to ldas.py. @weiyuan-jiang, does this make sense? |
PS: Or maybe get_gridname() would fit better into the make_bcs package? It's really some sort of reader of the *.til file. I don't know if we have a full py reader for the *.til file. If that exists, perhaps it could be modified to optionally only read the "grid_name" info. Also, the *.til file contains two grid names, the atm grid and the ocean grid. We should probably be clearer about get_gridname() only reading the name of the atm grid. |
Since it is called only by ldas_setup, I can move it to setup_utills |
d1a51fa
to
6ee5312
Compare
Zero diff testing with remap_package passed. |
b909338
No description provided.