-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add mode, inline cert iss & trust config to workload identity pool #13814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_iam_workload_identity_pool" "primary" {
inline_trust_config {
additional_trust_bundles {
intermediate_cas {
pem_certificate = # value needed
}
}
}
}
Resource: resource "google_iam_workload_identity_pool_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_iam_workload_identity_pool_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Missing doc report (experimental)The following resources have fields missing in documents.
|
0df77ca to
36bb4f4
Compare
Tests analyticsTotal tests: 24 Click here to see the affected service packages
Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_iam_workload_identity_pool" "primary" {
inline_trust_config {
additional_trust_bundles {
intermediate_cas {
pem_certificate = # value needed
}
}
}
}
Resource: resource "google_iam_workload_identity_pool_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_iam_workload_identity_pool_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Missing doc report (experimental)The following resources have fields missing in documents.
|
Tests analyticsTotal tests: 24 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
36bb4f4 to
f51ba43
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Missing doc report (experimental)The following resources have fields missing in documents.
|
Tests analyticsTotal tests: 29 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi @BBBmau, Thanks for taking the time to review this PR! Could you please remove the Regarding the failing VCR tests related to IAM policy ( In the meantime, would you be able to review the other parts of the PR related to the Workload Identity Pool changes? Please let me know if I can provide any further context to assist with the review. Thanks again! |
|
@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
Assigning a Googler for review, as the feature documentation is currently internal. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Missing doc report (experimental)The following resources have fields missing in documents.
|
Tests analyticsTotal tests: 29 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Tests analyticsTotal tests: 29 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Multiple resources addedThis PR adds multiple new resources: Missing doc report (experimental)The following resources have fields missing in documents.
|
|
Hi @c2thorn, it seems the CI step mmv1 / unit-tests (pull_request) is broken by third_party/terraform/services/netapp/resource_netapp_storage_pool_test.go.tmpl, which could be caused by #13929, could you please help verify that? I believe the Basic PR checks / disallow-large-prs (pull_request) is also broken by #13929, where I had to change |
Tests analyticsTotal tests: 29 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
You're right, we had an issue with unfortunate timing to a change in our CI. The fix PR was just merged. I believe to resolve it in your PR, you will need to rebase to a commit after 3cb32fa. Sorry for the added trouble. |
Hi @c2thorn, no worries. Thanks for your prompt help! Rebased this one on top of 3cb32fa. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Multiple resources addedThis PR adds multiple new resources: Missing doc report (experimental)The following resources have fields missing in documents.
|
Tests analyticsTotal tests: 29 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
c2thorn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the google_iam_workload_identity_pool_iam_* release note.
LGTM
1ffca3b
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.