Skip to content

validate template syntax needed#13929

Merged
ScottSuarez merged 6 commits intoGoogleCloudPlatform:mainfrom
ScottSuarez:tmpl-syntax-validate
May 14, 2025
Merged

validate template syntax needed#13929
ScottSuarez merged 6 commits intoGoogleCloudPlatform:mainfrom
ScottSuarez:tmpl-syntax-validate

Conversation

@ScottSuarez
Copy link
Copy Markdown
Contributor

@ScottSuarez ScottSuarez commented May 13, 2025

closes hashicorp/terraform-provider-google#21407
converted 147 templates to go code, condensed mmv1 unit tests into one github workflow. Added unit test to confirm no new templates that can be go code are being added.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@ScottSuarez ScottSuarez force-pushed the tmpl-syntax-validate branch from 0f4fd0e to 557fd8c Compare May 13, 2025 17:39
@ScottSuarez ScottSuarez force-pushed the tmpl-syntax-validate branch from 557fd8c to 13b05af Compare May 13, 2025 20:42
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 99 files changed, 1836 insertions(+), 1759 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 99 files changed, 1836 insertions(+), 1759 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez ScottSuarez requested a review from c2thorn May 13, 2025 21:12
Copy link
Copy Markdown
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this!

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez ScottSuarez added this pull request to the merge queue May 14, 2025
Merged via the queue into GoogleCloudPlatform:main with commit db88cf8 May 14, 2025
22 checks passed
@ScottSuarez ScottSuarez deleted the tmpl-syntax-validate branch May 14, 2025 17:45
@rileykarson rileykarson mentioned this pull request May 14, 2025
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request May 14, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 20, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto test if pull request is adding template files that do not need to be a template

3 participants