🐛[FrontEnd] Better error handling of invalid pre-registration data #6438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
force-pushed
the
fix/ui-pre-registration
branch
from
e63b68b to
92a3c83
Compare
pcrespov
requested review from
ignapas,
jsaq007 and
odeimaiz
as code owners
odeimaiz
reviewed
Sep 25, 2024
services/static-webserver/client/source/class/osparc/po/PreRegistration.js
Show resolved
Hide resolved
odeimaiz
approved these changes
Sep 25, 2024
ignapas
approved these changes
Sep 25, 2024
jsaq007
reviewed
Sep 25, 2024
services/static-webserver/client/source/class/osparc/po/PreRegistration.js
Show resolved
Hide resolved
|
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Oct 2, 2024
16 tasks
This was referenced Oct 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Improves UX when pre-registration data is invalid (e.g. JSON is invalid or server responds with error)
Before: it would "Submit" would spin indefinitely
After: it stops and shows error
Related issue/s
How to test
Manual testing (see screenshots above)
Dev-ops checklist
None