Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Mileage class that calculates the travel distance based on wheel rotation angles, adds corresponding tests, and updates the tooling to provide detailed clang-format output in both Docker and local environments.
- Added the Mileage class with methods to compute wheel and overall mileage.
- Implemented new unit tests for positive, negative, and zero angles.
- Updated Makefile and Dockerfile to handle clang-format more robustly.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/MileageTest.cpp | Added unit tests validating mileage calculations with angle bounds |
| modules/common/SystemInfo.h | Introduced global constants for wheel radius and tread width |
| modules/calculators/Mileage.h & .cpp | Implemented the Mileage class and its calculation methods |
| Makefile | Enhanced formatting messages and file detection logic |
| Dockerfile | Added clang-format installation |
…の角位置の変数を double ではなく int32_t 型を使用するように変更
takuchi17
requested changes
May 22, 2025
Collaborator
takuchi17
left a comment
takuchi17
left a comment
There was a problem hiding this comment.
処理はよさそうな感じです．リファクタリングだけよろしくお願いします．
takahashitom
requested changes
May 22, 2025
Collaborator
takahashitom
left a comment
takahashitom
left a comment
There was a problem hiding this comment.
軽微な修正だけお願いします。
実際に走らせてみたやつが Notion にあるので、見てみてください
takahashitom
requested changes
May 22, 2025
Collaborator
takahashitom
left a comment
takahashitom
left a comment
There was a problem hiding this comment.
修正箇所の範囲の指定をミスってたのであげなおしです
takahashitom
approved these changes
May 23, 2025
Collaborator
takahashitom
left a comment
takahashitom
left a comment
There was a problem hiding this comment.
問題ないと思います。
レビュー対応お疲れさまでした。
takuchi17
approved these changes
May 23, 2025
Collaborator
takuchi17
left a comment
takuchi17
left a comment
There was a problem hiding this comment.
修正ありがとうございます．
問題ないと思います．LGTM!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
チェックリスト
変更点