Update Vulkan SDK to version 1.4.304

[asuessenbach]

Description

Updating to Vulkan SDK 1.4.304 required some namespace adjustments in our code.

Fixes #1269

General Checklist:

Please ensure the following points are checked:

• My code follows the coding style
• I have reviewed file licenses
• I have commented any added functions (in line with Doxygen)
• I have commented any code that could be hard to understand
• My changes do not add any new compiler warnings
• My changes do not add any new validation layer errors or warnings
• I have used existing framework/helper functions where possible
• My changes do not add any regressions
• I have tested every sample to ensure everything runs correctly
• This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

• I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
• My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

• I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

• I have tested the sample on at least one compliant Vulkan implementation
• If the sample is vendor-specific, I have tagged it appropriately
• I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
• Any dependent assets have been merged and published in downstream modules
• For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
• For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
• For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

[SRSaunders]

@asuessenbach this looks good, but may also affect the debug callback in shader_debugprintf.

Can I please ask you to hold off on this PR until #1187 is merged? Hopefully will be very soon as it's been sitting a long time. Once that is done, you could add any necessary shader_debugprintf callback changes to this PR.

[SaschaWillems]

LGTM!

[SRSaunders]

@asuessenbach #1187 is now merged.

Please feel free to convert the debug callback in shader_debugprintf to the vk:: namespace if required. Perhaps it's not in this case, but I'll leave that up to you to determine. Thanks.

[asuessenbach]

@SRSaunders as the shader_debugprintf sample uses the C-bindings of vulkan, there's no need to change anything here. The adjustments are needed for the C++-bindings only.

[gary-sweet]

I'm seeing a new build warning with this change in place:

samples/api/hpp_hello_triangle/hpp_hello_triangle.cpp: In member function 'vk::Instance HPPHelloTriangle::create_instance(const std::vector<const char*>&, const std::vector<const char*>&)':
samples/api/hpp_hello_triangle/hpp_hello_triangle.cpp:450:80: warning: 'vk::DebugUtilsMessengerCreateInfoEXT::DebugUtilsMessengerCreateInfoEXT(vk::DebugUtilsMessengerCreateFlagsEXT, vk::DebugUtilsMessageSeverityFlagsEXT, vk::DebugUtilsMessageTypeFlagsEXT, PFN_vkDebugUtilsMessengerCallbackEXT, void*, const void*)' is deprecated: This constructor is deprecated. Use the one taking function pointer types from the vk-namespace instead. [-Wdeprecated-declarations]
  450 |                                                  debug_utils_messenger_callback);
      |                                                                                ^
In file included from third_party/vulkan/include/vulkan/vulkan.hpp:8864,
                 from samples/api/hpp_hello_triangle/hpp_hello_triangle.h:20,
                 from samples/api/hpp_hello_triangle/hpp_hello_triangle.cpp:19:
third_party/vulkan/include/vulkan/vulkan_structs.hpp:22494:5: note: declared here
22494 |     DebugUtilsMessengerCreateInfoEXT( VULKAN_HPP_NAMESPACE::DebugUtilsMessengerCreateFlagsEXT flags_,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[asuessenbach]

The ios build seems to be broken!

[SaschaWillems]

LGTM 👍🏻

[marty-johnson59]

3 approvals - merging