Skip to content

Conversation

@namiroues
Copy link
Contributor

The output from these changes is shown in the snapshot
mda_web_sidebar

@namiroues namiroues requested a review from orbeckst March 10, 2025 12:34
@namiroues namiroues self-assigned this Mar 10, 2025
@namiroues namiroues requested a review from micaela-matta March 10, 2025 12:35
@namiroues namiroues changed the title add icons and reorder pages on sidebar sdg23 restructure sidebar in website Mar 10, 2025
@namiroues namiroues changed the title sdg23 restructure sidebar in website Sdg23 restructure sidebar in website Mar 10, 2025
@namiroues
Copy link
Contributor Author

This PR addresses #441

@namiroues namiroues added the SDG23 work on Small Development Grant 2023 label Mar 10, 2025
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the condensing of the side bar.

However, I would not want to move about and especially blog under pages. Originally, pages/ was just a way to avoid cluttering the top level with too many pages. The directory itself has no significance to the Jekyll template. In principle the way to use the template is to put pages into the top level.

@namiroues namiroues removed their assignment Mar 11, 2025
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried other methods before but couldn't get them to work. Do you have any suggestions for keeping the About page at the top level while maintaining the correct sidebar order?

At the moment, About and Blog are floating to the top automatically because we never defined order for them; I just tried and just adding order: 99 in the front matter makes them change position. Does this help you to define the menu order that you want?

See also https://jekyllrb.com/docs/pages/ on page organization in Jekyll.

@namiroues
Copy link
Contributor Author

Thanks, @orbeckst for your comments! I have addressed them. (Note: I added a TODO to reorder the pages after all PRs are merged.)

@orbeckst
Copy link
Member

The build fails — perhaps merge current master into it as this may have been the fix from PR #454 .

@orbeckst
Copy link
Member

@namiroues can you resolved the conflict, please? Might require some care so that nothing gets accidentally deleted.

@namiroues namiroues force-pushed the sdg23-restructure-side-bar-3 branch from 86f5206 to 7076ff5 Compare March 28, 2025 15:49
@namiroues namiroues force-pushed the sdg23-restructure-side-bar-3 branch from 7076ff5 to 6235184 Compare March 28, 2025 16:03
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

(reordering in separate PR)

@orbeckst orbeckst self-assigned this Mar 30, 2025
@orbeckst orbeckst merged commit 34fe6a2 into MDAnalysis:master Mar 30, 2025
1 check passed
@namiroues namiroues deleted the sdg23-restructure-side-bar-3 branch April 2, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SDG23 work on Small Development Grant 2023

Development

Successfully merging this pull request may close these issues.

3 participants