-
Notifications
You must be signed in to change notification settings - Fork 47
Sdg23 restructure sidebar in website #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sdg23 restructure sidebar in website #442
Conversation
|
This PR addresses #441 |
orbeckst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the condensing of the side bar.
However, I would not want to move about and especially blog under pages. Originally, pages/ was just a way to avoid cluttering the top level with too many pages. The directory itself has no significance to the Jekyll template. In principle the way to use the template is to put pages into the top level.
orbeckst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried other methods before but couldn't get them to work. Do you have any suggestions for keeping the About page at the top level while maintaining the correct sidebar order?
At the moment, About and Blog are floating to the top automatically because we never defined order for them; I just tried and just adding order: 99 in the front matter makes them change position. Does this help you to define the menu order that you want?
See also https://jekyllrb.com/docs/pages/ on page organization in Jekyll.
|
Thanks, @orbeckst for your comments! I have addressed them. (Note: I added a TODO to reorder the pages after all PRs are merged.) |
|
The build fails — perhaps merge current master into it as this may have been the fix from PR #454 . |
|
@namiroues can you resolved the conflict, please? Might require some care so that nothing gets accidentally deleted. |
86f5206 to
7076ff5
Compare
7076ff5 to
6235184
Compare
orbeckst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice!
(reordering in separate PR)
The output from these changes is shown in the snapshot
