Skip to content

Update trove_order.py to reflect latest API (joining on #15 and #32)#20

Open
alberthdev wants to merge 2 commits intoMayeulC:poc-trovefrom
alberthdev:poc-trove
Open

Update trove_order.py to reflect latest API (joining on #15 and #32)#20
alberthdev wants to merge 2 commits intoMayeulC:poc-trovefrom
alberthdev:poc-trove

Conversation

@alberthdev
Copy link

@alberthdev alberthdev commented Jan 23, 2019

Based on #15 (comment). Hope this pushes things along for you! Testing seems to work alright for getting things downloaded (aka what I'm looking for), not sure if sizes are correct or not for resuming later.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 51

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 58.342%

Totals Coverage Status
Change from base Build 44: 0.1%
Covered Lines: 535
Relevant Lines: 917

💛 - Coveralls

@MayeulC
Copy link
Owner

MayeulC commented Feb 7, 2019

Thank you so much for this! I was hoping to be able to review and merge that sooner, but I ended up having much less time than anticipated. I'll still do it as soon as possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants