chore: signing bug

[coodos]

Description of change

Issue Number

Type of change

• Breaking (any change that would cause existing functionality to not work as expected)
• New (a change which implements a new feature)
• Update (a change which updates existing functionality)
• Fix (a change which fixes an issue)
• Docs (changes to the documentation)
• Chore (refactoring, build scripts or anything else that isn't user-facing)

How the change has been tested

Change checklist

• I have ensured that the CI Checks pass locally
• I have removed any unnecessary logic
• My code is well documented
• I have signed my commits
• My code follows the pattern of the application
• I have self reviewed my code

Summary by CodeRabbit

• New Features

  • Enabled real hardware-backed cryptographic signing in the QR scan flow, replacing simulated signing.
  • Automatically generates a default key if needed, retrieves the public key, and posts a genuinely signed payload.
  • Blind voting now attempts to fetch a real public key (with fallback if hardware is unavailable).

• Security

  • Added verification that the provided public key matches the user who created the signing session in both eVoting and Group Charter Manager services.
  • Normalized comparisons, detailed logging, and clear error handling on mismatch or verification failure.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Client app now performs real hardware-backed signing via Tauri crypto APIs, replacing simulated signing. Backend services add a verification step ensuring the submitted publicKey matches the session user’s ename before proceeding with existing signature/message checks. Blind-vote path fetches a hardware public key (stored, not used).

Changes

Cohort / File(s)	Summary
Client: Real hardware signing infrastructure/eid-wallet/src/routes/(app)/scan-qr/+page.svelte	Replaced simulated signing with Tauri crypto: check hardware, generate default key if absent, get public key, sign message, POST signedPayload. Added logging. Blind-vote path retrieves hardware public key with fallback to vault.ename.
Server: eVoting verification platforms/evoting-api/src/services/SigningService.ts	Added assertion ensuring publicKey matches session user’s ename (normalized by stripping leading @). Uses dynamic import of UserService. On mismatch or errors, returns explicit errors; on pass, continues existing verification.
Server: Charter verification platforms/group-charter-manager-api/src/services/CharterSigningService.ts	Same publicKey vs user ename assertion as above using dynamic UserService; logs violations, throws on mismatch, otherwise proceeds with existing signature/session finalization.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant W as Wallet App (scan-qr)
  participant HW as Crypto HW (Tauri)
  participant API as Signing API
  participant US as UserService

  U->>W: Initiate sign/submit
  W->>HW: exists() / generate() / getPublicKey()
  HW-->>W: PublicKey
  W->>HW: signPayload(message)
  HW-->>W: Signature
  W->>API: POST signedPayload {message, signature, publicKey}
  API->>US: getUser(session.userId)
  US-->>API: User {ename}
  API->>API: Assert publicKey matches user ename
  alt Mismatch or error
    API-->>W: Error (public key does not match / verification failed)
  else Match
    API->>API: Verify signature/message (existing flow)
    API-->>W: Success
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Feat/w3ds evoting #290 — Touches the same eVoting signing flow and SigningService/SigningController integration.
• feat: setup hw crypto #295 — Similar shift from simulated to hardware-backed signing using exists/getPublicKey/generate/signPayload.

Suggested reviewers

• sosweetham

Poem

I thump my paws—secure and bright,
Keys now minted in hardware light.
Ename checked, no tricks slip through,
Sign and verify, strict and true.
With whiskered pride I stamp and seal—
A rabbit’s vote, cryptographically real. 🐰🔐

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9b0ec98 and b86f043.

📒 Files selected for processing (3)

• infrastructure/eid-wallet/src/routes/(app)/scan-qr/+page.svelte (3 hunks)
• platforms/evoting-api/src/services/SigningService.ts (1 hunks)
• platforms/group-charter-manager-api/src/services/CharterSigningService.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/signing-bug

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.