fix: Added missing status and bounding box for RT feeds #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcpitre
changed the title
jcpitre
commented
Feb 26, 2025
| subquery = gtfs_rt_feed_filter.filter( | ||
| select(Gtfsrealtimefeed.id) | ||
| .join(Location, Gtfsrealtimefeed.locations) | ||
| .join(Location, Gtfsrealtimefeed.locations, isouter=True) |
Collaborator
Author
There was a problem hiding this comment.
Added this isouter so GTFS RT feeds that don't have locations are still returned.
See #925
davidgamez
deleted the
906-missing-column-values-for-gtfs-realtime-feeds-in-sources_v2csv
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #906 and #899 and #925
Combined GTFS and GTFS_RT data extraction for the common members, giving status and redirect for RT feeds by default.
For the bounding box with the RT feeds used the bounding box of the associated GTFS feed.
Expected behavior:
In the exported csv file, the realtime feeds should now have status, redirect and bounding box data.
The bounding box data should be the one from the associated GTFS feed.
Tested with the dev environment and spot checking some GTFS rt feeds.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything