Skip to content

fix: add missing export for embedded exploration#1933

Merged
vgeorge merged 2 commits intomainfrom
fix/export-embedded
Dec 2, 2025
Merged

fix: add missing export for embedded exploration#1933
vgeorge merged 2 commits intomainfrom
fix/export-embedded

Conversation

@slesaad
Copy link
Member

@slesaad slesaad commented Dec 2, 2025

Related Ticket: {link related ticket here}

Description of Changes

- Removes LayoutProps - it's not needed and is also breaking the library when importing in another app for some reason (this is false apparently, it is needed so we need to figure out whats causing the issue)

  • Adds export for EmbeddedExploration

Validation / Testing

yarn link and import into https://github.com/US-GHG-Center/ghgc-ena.

@netlify
Copy link

netlify bot commented Dec 2, 2025

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 6706745
🔍 Latest deploy log https://app.netlify.com/projects/veda-ui/deploys/692f07fb1069ea0008291783
😎 Deploy Preview https://deploy-preview-1933--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@slesaad slesaad requested a review from vgeorge December 2, 2025 16:01
@slesaad
Copy link
Member Author

slesaad commented Dec 2, 2025

oof - just realized that it doesn't hide the header and footer without LayoutProps. need to figure out how to do that without breaking the library

@vgeorge
Copy link
Contributor

vgeorge commented Dec 2, 2025

As discussed, lets merge this PR as is and make a manual release so it can be used in ghgc-ena instance soon. Let's track this issue with LayoutProps on #1929.

@vgeorge vgeorge merged commit 950ffad into main Dec 2, 2025
13 checks passed
@vgeorge vgeorge deleted the fix/export-embedded branch December 2, 2025 17:46
@vgeorge vgeorge mentioned this pull request Dec 2, 2025
6 tasks
slesaad added a commit to US-GHG-Center/veda-config-ghg that referenced this pull request Dec 9, 2025
- # Changelog
- ## 🎉 Features
- feat: Expose VedaMap
[#1878](NASA-IMPACT/veda-ui#1878)
- feat: migrate ExternalLinkFlag to USWDS
[#1887](NASA-IMPACT/veda-ui#1887)
- feat: Share button to URL shortener
[#1905](NASA-IMPACT/veda-ui#1905)
- feat: embed mode for e&a
[#1922](NASA-IMPACT/veda-ui#1922)
- ## 🚀 Improvements
  - chore: trigger netlify redeploy
- refactor: Preset selector
[#1874](NASA-IMPACT/veda-ui#1874)
- refactor: retire Collecticons
[#1893](NASA-IMPACT/veda-ui#1893)
- refactor: migrate dataset layer card icons to USWDS
[#1891](NASA-IMPACT/veda-ui#1891)
- refactor: Replace Collecticons in legacy footer and connections
section [#1890](NASA-IMPACT/veda-ui#1890)
- refactor: migrate catalog components to USWDS (except catalog-card)
[#1888](NASA-IMPACT/veda-ui#1888)
- ci: prevent cleanup from deleting latest valid release tag
[#1910](NASA-IMPACT/veda-ui#1910)
- ci: disable the slack notifications until we stabilize the release
workflow [#1909](NASA-IMPACT/veda-ui#1909)
- ci: re-enable slack notifications for failed releases
[#1911](NASA-IMPACT/veda-ui#1911)
- docs: Update development instructions for storybook
[#1914](NASA-IMPACT/veda-ui#1914)
- test: Add micasa to mock datasets for testing cmr timeseries
[#1896](NASA-IMPACT/veda-ui#1896)

 
- ## 📊 Dataset Updates
- fix: Updates for SEDAC dataset landing
page[#840](#840)
- ## 📝 Stories Updates
 - ## 🐛 Fixes
- fix: make release workflow idempotent and reset version to last
successful release
[#1908](NASA-IMPACT/veda-ui#1908)
- fix: wmts copy url
[#1886](NASA-IMPACT/veda-ui#1886)
- fix: 744/search bar fix
[#1903](NASA-IMPACT/veda-ui#1903)
- fix: Rename React component files from .js to .jsx
[#1901](NASA-IMPACT/veda-ui#1901)
- fix: migrate scrollytelling from CollecticonCircleXmark to USWDS
[#1885](NASA-IMPACT/veda-ui#1885)
- fix: remove Collecticons from EmptyHub and TimelineZoomControls
components [#1884](NASA-IMPACT/veda-ui#1884)
- fix: [veda-ui-1864] Update colormapscale to default to mdx rescale
[#1916](NASA-IMPACT/veda-ui#1916)
- fix: properly load API_URL_SHORTENER_ENDPOINT through VedaUI context
[#1924](NASA-IMPACT/veda-ui#1924)
- fix: Guided tour doesn't work in exported ExplorationAndAnalysis
component [#1921](NASA-IMPACT/veda-ui#1921)
- fix: selected pill alignment in data-catalog layer component
[1932](NASA-IMPACT/veda-ui#1932)
- fix: update compare swiper interactions to prevent interaction with
map controls [#1930](NASA-IMPACT/veda-ui#1930)
- fix: guard WMS date domain lookup in scrollytelling
[1926](NASA-IMPACT/veda-ui#1926)
- fix: update cmr query key to cache bust on start and end date
[#1928](NASA-IMPACT/veda-ui#1928)
- fix: add missing export for embedded exploration
[#1933](NASA-IMPACT/veda-ui#1933)
- fix: 1068 update mapbox compare
[#1947](NASA-IMPACT/veda-ui#1947)
- fix: Fix EMIT Bug with Overlapping Plumes
[#798](US-GHG-Center/ghgc-architecture#798)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants