Update submodules of benchmark#107
Merged
fmalatino merged 19 commits intoNOAA-GFDL:benchmarkfrom Mar 11, 2025
Merged
Conversation
…mutually incompatible versions (NOAA-GFDL#84)
* updated generate_eta_files * remove notebook, add script * lint --------- Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>
* Updates to allow use of python3.11 * Removed main_unit_tests.yml as it is covered by tests in containers * Updated images for unit tests with openmpi and mpich
* updated generate_eta_files * remove notebook, add script * lint * correct path * update constraints * python3 execute * Update main_unit_tests_mpich.yaml * Update main_unit_tests_mpich.yaml * update input directory * get ..s correct * lint --------- Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>
…A-GFDL#89) * test * tet * fix test dir * test * checkout pace * rename * test * rm * remove dir * fix name * test * pyshield * test * fix trigger mistake * test * change lint version * remove push * lint --------- Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>
…tdated pull request template (NOAA-GFDL#86) * Changed workflows to use python 3.11.7, added pytest-subtests to requirments_dev.txt * Matched package dependencies between main and develop branches * Updating constraints file * Updating Dockerfile to use 3.11-slim-bookworm base python image
* fix trigger mistake * fix spacking * update yaml files * rename lint.yaml * remove backup yaml file * simply pull request trigger * beloved lint --------- Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>
…FDL#88) * add build script for intel oneapi and gcc compiler separately * update the python version and remove the link time optimization option for gcc
…NOAA-GFDL#92) * Removed test_eta.py, moved to NDSL/tests/grid
…FDL#99) * Updated README to include directions for generating eta files * Linting * Updated baroclinic_c2.yaml to generate zarr output
…DL#101) * Updated submodules as of 21 Jan 2025, and added baroclinic run to github workflow
* Update netcdf version * also upgrade pip * update ndsl
* Updated submodules to versions as of 15 Jan 2025 * Updated submodules as of 21 Jan 2025, and added baroclinic run to github workflow * Updated submodules as of 5 09:49 March 2025
oelbert
reviewed
Mar 10, 2025
Collaborator
oelbert
left a comment
oelbert
left a comment
There was a problem hiding this comment.
Small question about dependency changes
Comment on lines
-11
to
-13
| module load gcc-native/12.3 | ||
| module load boost/1.85.0 | ||
| module load miniforge |
Collaborator
There was a problem hiding this comment.
Are these changes correct for Gaes c5?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
benchmarkbranch to contain the latest versions of the Pace submodulesChecklist: