fetchFromRadicle: init#434360
Conversation
dfcd8d2 to
1e4fe75
Compare
matthiasbeyer
left a comment
There was a problem hiding this comment.
Only a small documentation suggestion, everything else looks fine to me.
Do we need docs somewhere for this? Probably?
|
I'd appreciate if you could wait for my review here. The reason is that Radicle 1.3 now supports Canonical References, which means that one will not have to access tags via a particular namespace anymore in the future. In the next weeks, probably all of the Radicle-hosted packages will switch to Canonical References. However, such a fetcher should still allow fetching from a particular namespace, in my opinion. I would like to read through the suggested changes here with a fresh brain, and the implications of Canonical References in mind. |
|
I have implemented something similar before, just for reference: https://github.com/radicle-nix/radicle-nix/blob/main/pkg/fetchFromRadicleBridge/package.nix Fetching via What would deserve the name |
lorenzleutgeb
left a comment
There was a problem hiding this comment.
OK, from what I understand, just omitting the node argument would work nicely with Canonical References. I just made a minor suggestion.
Please think about the name once more, maybe this should be called something like:
fetchFromRadicleHttpd(for now,radicle-httpdis really the only server compatible with this)fetchFromRadicleBridgeas we're using the given seed as a "bridge" to the Radicle network. Maybe even rename theseedargument tobridge.fetchFromRadicleHttpfetchFromRadicleSeedas this will rely on a particular seed being available.
1e4fe75 to
77f26b6
Compare
|
Hey @lorenzleutgeb, thanks for the feedback! I applied the change you suggested and removed the default value for Regarding the name, let's assume we eventually want to add another implementation which starts a node itself and thus doesn't require a seed. I think we could simply use the same |
77f26b6 to
9c9cfe8
Compare
Added some documentation to the fetchers section |
There was a problem hiding this comment.
Is the .git suffix always true?
There was a problem hiding this comment.
matthiasbeyer
left a comment
There was a problem hiding this comment.
Besides the one (non-blocking) comment, 👍
9c9cfe8 to
74dd8c4
Compare
|
Rebased onto master, changed I checked all FODs again using Are there any blockers remaining? |
74dd8c4 to
9fbba6d
Compare
9fbba6d to
914c4f2
Compare
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-434360-to-release-25.05 origin/release-25.05
cd .worktree/backport-434360-to-release-25.05
git switch --create backport-434360-to-release-25.05
git cherry-pick -x 5e2cc452717a454ca3517caf85eba3ede38d71f3 0f4642c7961dfc1348b607f47ff8c9a8cf6b3656 036be6edbae5f37143def9dba764ceb8b387b5e5 1ddbbb16715d268ff003ab7b11821cd04bb0b4e2 914c4f23461c546d580675742b0c5bd4f04b4796 |
Add a fetcher for projects hosted on Radicle.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.