Dynamic reports #228
Merged
Dynamic reports #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis update introduces several new features and refactors across the server, reporting, and testing layers. The HTTP server now supports website routes with EJS templating and improved shutdown logic, including forced connection termination and timeouts. The reports module is modularized with new data collection and validation functions, internal link generation, and enhanced template handling using EJS partials for head, navigation, and footer. JSON schemas for index and project data are added, along with corresponding validators. The store layer gains a method for fetching projects by ID. Comprehensive tests are added for website routes and internal link generation. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HTTPServer
participant WebRouter
participant Store
participant Reports
participant Templates
User->>HTTPServer: GET /
HTTPServer->>WebRouter: Handle /
WebRouter->>Reports: collectIndexData(knex)
Reports->>Store: Fetch projects, checklists, checks
Store-->>Reports: Data
Reports-->>WebRouter: Validated index data
WebRouter->>Templates: Render index.ejs with data
Templates-->>User: HTML response
User->>HTTPServer: GET /projects/:id
HTTPServer->>WebRouter: Handle /projects/:id
WebRouter->>Store: getProjectById(id)
Store-->>WebRouter: Project or null
alt Project found
WebRouter->>Reports: collectProjectData(knex, id)
Reports->>Store: Fetch project-related data
Store-->>Reports: Data
Reports-->>WebRouter: Validated project data
WebRouter->>Templates: Render project.ejs with data
Templates-->>User: HTML response
else Project not found or invalid id
WebRouter->>Templates: Render notFound.ejs
Templates-->>User: 404 HTML response
end
Possibly related PRs
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Use integrity check for FE libraries - Remove unused static resources from server - Remove dependency `serve-index` - Add test cases for `validateProjectData` and `validateIndexData` schemas - Proper ordering of shutdown steps - More graceful handling of active connections - Better error handling and logging - Move to `__dirname` from `process.cwd()` - Fix bug filtering scorecard ownership - Enhance navigation accessibility
Member
Author
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
Author
|
I will handle the last suggestions in my next PR |
UlisesGascon
added a commit
that referenced
this pull request
May 3, 2025
Ref: #228 (comment) - Replace `process.cwd()` with `__dirname` for reliable path resolution - Fix HTTP server connection listener leak on multiple start/stop cycles - Add default empty string for ref parameter in internalLinkBuilder - Replace `parseInt()` with `Number()` for better type conversion - Add `implementation_status` enum to `indexData` schema
UlisesGascon
added a commit
that referenced
this pull request
May 3, 2025
Ref: #228 (comment) - Replace `process.cwd()` with `__dirname` for reliable path resolution - Fix HTTP server connection listener leak on multiple start/stop cycles - Add default empty string for ref parameter in internalLinkBuilder - Replace `parseInt()` with `Number()` for better type conversion - Add `implementation_status` enum to `indexData` schema
UlisesGascon
added a commit
that referenced
this pull request
May 3, 2025
Ref: #228 (comment) - Replace `process.cwd()` with `__dirname` for reliable path resolution - Fix HTTP server connection listener leak on multiple start/stop cycles - Add default empty string for ref parameter in internalLinkBuilder - Replace `parseInt()` with `Number()` for better type conversion - Add `implementation_status` enum to `indexData` schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #219
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Tests
Chores