Skip to content

GS/TC: Correct some preload behaviour on merging targets#13856

Open
refractionpcsx2 wants to merge 3 commits intomasterfrom
gs_preloadtargetadjust
Open

GS/TC: Correct some preload behaviour on merging targets#13856
refractionpcsx2 wants to merge 3 commits intomasterfrom
gs_preloadtargetadjust

Conversation

@refractionpcsx2
Copy link
Copy Markdown
Member

Description of Changes

Correct some preload behaviour on merging targets

Rationale behind Changes

Data was becoming errornously dirty or deleted when it didn't need to be, causing some problems when Tex in RT/RT in RT was enabled.

Suggested Testing Steps

Test Gran Turismo 4 with Tex in RT enabled (required to get around related issues)

Did you use AI to help find, test, or implement this issue or feature?

No

Copy link
Copy Markdown
Contributor

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add Tex in rt in db too, dunno if the other games need it.

@refractionpcsx2
Copy link
Copy Markdown
Member Author

I've no idea, Tourist Trophy might, but I can't confirm it.

@refractionpcsx2
Copy link
Copy Markdown
Member Author

Added gamedb entries

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Jackie Chan Adventures, Valkyrie Profile 2, and other games (which don't use tex in rt) just in case. No regressions found.

@refractionpcsx2
Copy link
Copy Markdown
Member Author

Thanks, I actually have some more work to do, GT4 is being a nightmare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants