Reverted change for gripper objectives in satellite_sim. #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@davetcoleman Thanks for the hints. |
davetcoleman
approved these changes
Sep 25, 2025
Member
davetcoleman
left a comment
davetcoleman
left a comment
There was a problem hiding this comment.
I made this follow up enhancement to avoid this in the future:
https://github.com/PickNikRobotics/moveit_pro/issues/14545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://github.com/PickNikRobotics/moveit_pro/issues/14362
Description
I reverted the names of "Open Gripper" and Close "Gripper" objectives, including their use in the objective "Grapple Moving Satellite via Fiducial Tracking"
Tests
If you work in dev mode, remember to launch
ros2 launch space_satellite_sim agent_bridge.launch.xmlinstead of
agent_bridge.appCheck that the gripper open and close in teleoperation mode and run the objective "Grapple Moving Satellite via Fiducial Tracking".