Hackathon count boxes objective #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
We'll have to move this PR to core now |
Author
|
Resuming work on this PR since example ws is back out of core |
Author
|
pre-commit failure fixed with #435, integration test failure is flakes |
Collaborator
|
I added some comments and rearranged a few sequence nodes to start, then I wrapped all the objectives in a parent objective that warns you the absolute file path needs to be updated. The subtrees will propagate the file paths set at the parent level |
MikeWrock
approved these changes
Oct 29, 2025
Collaborator
|
I've hit approve but can @henrygerardmoore or @bgill92 just run the objective one more time to triple check my last commit please? |
|
@MikeWrock The Objective worked as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the username used in CI? We can switch
/home/henryor/home/bilalto that so it passes tests.Assigning to @bgill92 because right now the navigation values don't seem to work, the robot crashes into stuff when I run
Count Boxes