Add ROS2 Jazzy Jalisco support#104
Open
bryceag11 wants to merge 8 commits intoPickNikRobotics:mainfrom
Open
Conversation
This commit adds full compatibility with ROS 2 Jazzy (Ubuntu 24.04). Changes: - Update ResourceManager API for Jazzy compatibility in tests - Implement new on_init(HardwareComponentInterfaceParams) signature - Fix nodiscard warnings by checking set_value() return values - Replace deprecated get_value() with get_optional<double>() - Add proper error handling for command interfaces - Fix format string warnings in logging - Add CMake policy CMP0060 to suppress path cycle warnings - Update README with Jazzy installation instructions Tested on: - Ubuntu 24.04 LTS (Noble Numbat) - ROS 2 Jazzy Jalisco
Member
|
#105 will communicate the change that |
Member
|
This may not be needed with #108 merged in, a comparison of approaches will be needed. |
Correct vcs import target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for ROS 2 Jazzy Jalisco (Ubuntu 24.04) with necessary API compatibility updates.
Changes
1. Hardware Interface API Updates
ResourceManagerconstructor to use new Jazzy signature withrclcpp::Clockandrclcpp::Loggeron_init(const HardwareComponentInterfaceParams&)method alongside deprecated signature for backward compatibilityrclcpp::ClockType::SYSTEM_TIMEtoRCL_SYSTEM_TIMEconstant#include <hardware_interface/types/hardware_component_interface_params.hpp>2. Controller Interface Updates
LoanedCommandInterface::set_value()(now marked with[[nodiscard]])get_value()withget_optional<double>()for safer value retrieval3. CMake and Build Improvements
4. Documentation
Modified Files
robotiq_driver/tests/test_robotiq_gripper_hardware_interface.cpprobotiq_driver/src/hardware_interface.cpprobotiq_driver/include/robotiq_driver/hardware_interface.hpprobotiq_controllers/src/robotiq_activation_controller.cpprobotiq_controllers/CMakeLists.txtrobotiq_hardware_tests/CMakeLists.txtREADME.mdTesting
.reposfileDependencies
No new dependencies added. Uses existing
serialpackage fromtylerjw/serialimported via the existing.reposfile.Backward Compatibility
on_init(const HardwareInfo&)signature that calls new signatureTesting Environment