Skip to content

Conversation

@davidhewitt
Copy link
Member

3.13.2 broke ffi-check for PyConfig due to ABI break upstream, should have been fixed in 3.13.3.

Let's also ignore _PyCoLineInstrumentationData temporarily to unblock CI, will be removed in #5064

@davidhewitt davidhewitt enabled auto-merge April 11, 2025 08:26
@davidhewitt
Copy link
Member Author

Free threaded tests seem legitimately broken in async code, cc @ngoldbaum

I'm going to try to reproduce locally.

auto-merge was automatically disabled April 11, 2025 10:29

Pull request was closed

@davidhewitt davidhewitt reopened this Apr 11, 2025
@davidhewitt
Copy link
Member Author

I can reproduce with cargo stress --features=experimental-async --test=test_coroutine, it's flaky so I'll try to rerun and merge this but will then try to fix the threading bug before releasing 0.24.2.

@davidhewitt davidhewitt enabled auto-merge April 11, 2025 10:31
@davidhewitt davidhewitt mentioned this pull request Apr 11, 2025
@davidhewitt davidhewitt added this pull request to the merge queue Apr 11, 2025
Merged via the queue into PyO3:main with commit c545b2e Apr 11, 2025
52 checks passed
@davidhewitt davidhewitt deleted the ffi-check-3.13 branch April 11, 2025 13:38
newcomertv pushed a commit to newcomertv/pyo3 that referenced this pull request Apr 28, 2025
…mentationData` (PyO3#5065)

* ci: re-enable ffi check on 3.13 for PyConfig, ignore `_PyCoLineInstrumentationData`

* force 3.13 jobs to use latest 3.13.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant