Conversation
- define a default national_co2_budget - allow empty scenario, which falls back to the defaults specified in pypsa.de.yaml
cpschau
left a comment
cpschau
left a comment
There was a problem hiding this comment.
Tested it in combination with another cascaded SysGF config and scenarios and it worked. Before, I always had to specify a (redundant) source for German CO2 limit as well as some additional industry parameters, which seems to be resolved with this PR. Thank you @lindnemi!
toniseibold
left a comment
toniseibold
left a comment
There was a problem hiding this comment.
Would be great to see are more extensive explanation in the PR what is happening why (e.g. changing the paths in the Snakefile which otherwise leads to errors since the workflow tries to download the ariadne database mutliple times)
I think this is useful information when new developers look at code in 5 years wondering
I'm not sure if it's necessary to get links dynamically for the national co2 target. Imo this repo does and should not work for other countries
| # Adding Efuel imports and exports to constraint | ||
| incoming_oil = n.links.index[n.links.index == "EU renewable oil -> DE oil"] | ||
| outgoing_oil = n.links.index[n.links.index == "DE renewable oil -> EU oil"] | ||
| incoming_oil = n.links.index[n.links.index == f"EU renewable oil -> {ct} oil"] |
There was a problem hiding this comment.
why? a national target for any other country does not make much sense since one would have to change code in modify_prenetwork before it really makes sense
Tested it with e.g. Spain - I would rather see an error/warning that the national target does not account for e.g. oil/methanol/gas.
There was a problem hiding this comment.
This PR:
Changes the syntax of the national_co2_budget configuration to comply with that of other constraints
Only this constraint used to be year:ct:value, now it is ct:year:value just like the others. While changing that I made the code more general for future development (which it already was in some parts, just not consistently). I will add an error to avoid your Spain case
* start by making Mix the default scenario * make script more robust * - change syntax of national co2_budget - define a default national_co2_budget - allow empty scenario, which falls back to the defaults specified in pypsa.de.yaml * simplify scenario definitions, fallback to defaults more often * change prefix * ariadne_template is data not resources * fix rounding error * disable interactive mode in final plotting script * decouple ariadne DB pre-workflow from scenario management * fix key error * error if co2 budget for country other than DE specified * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * improve wording --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
3 participants
This PR:
Mixthe default scenario and changes pypsa.de.yaml accordinglyMixhas to be specified explicitlyBefore asking for a review for this PR make sure to complete the following checklist:
ariadne_allcompletes without errorsexport_ariadne_variableshas been adapted to the changesChangelog.mdmainhas been merged into the PRYYYYMMDDdescriptive_title