Squin Operator Sites Analysis #11
Conversation
|
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Hi @Roger-luo I believe this is a reasonable implementation of the squin operator shape analysis. I understand you also mentioned a "propagation of unitarity" in #11 but from what I can tell this would require something similar to a const prop analysis + wrap const rewrite? As in I'd have something like a It just doesn't seem very idiomatic to me to try and kill two birds with one stone in analysis here. If the behavior you see in |
Roger-luo
left a comment
Roger-luo
left a comment
There was a problem hiding this comment.
neat PR, just some minor revision needed, great work!
Roger-luo
added
priority: high
johnzl-777
changed the title
|
@Roger-luo I did my best to implement the name changes you requested but also did my best to pick some names that were still clear enough that one can disambiguate between them. Credit to @weinbe58 for helping me think through some of the names in discussion! I also added unit tests to try to cover all the proper codepaths (: |
Roger-luo
left a comment
Roger-luo
left a comment
There was a problem hiding this comment.
nice! I think the code is great to go! Just remmeber to cleanup your playground
squin_op_playground.py
Outdated
| @@ -0,0 +1,59 @@ | |||
| from kirin import ir, types | |||
There was a problem hiding this comment.
you wanna delete the playground?
There was a problem hiding this comment.
Yes! Thank you for catching that. I should probably do a local ignore for any _playground.py files moving forward
There was a problem hiding this comment.
I usually use a main.py as my playground it's in the .gitignore already IIRC
┆Issue is synchronized with this Jira Task by Unito