fix: dont do keyboard shortcuts when field editors open #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHenning
approved these changes
May 30, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Thanks @maribethb, LGTM! Just had one comment that might lead to a slight test simplification.
Comment on lines
125
to
127
| await this.browser.keys(Key.Ctrl); | ||
| await this.browser.keys('x'); | ||
| await this.browser.keys(Key.Ctrl); // release ctrl key |
Collaborator
There was a problem hiding this comment.
Could you just use await this.browser.keys([Key.Ctrl, 'x']); instead? I think we do that elsewhere.
Collaborator
Author
There was a problem hiding this comment.
Oh, I guess so. The webdriver documentation includes a very confusing statement that modifier keys will be considered held down until you trigger them again, but then their example with copy and paste doesn't do anything related to that, so... I guess it's fine.
This was referenced May 30, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RaspberryPiFoundation/blockly#9101
Depends on RaspberryPiFoundation/blockly#9110
Adds a check to the
canCurrentlyNavigatefunction to make sure nothing has ephemeral focus.This is safe to do because this function is only used by action preconditions.
It's even safe to do for the escape shortcut because that shortcut only applies when the flyout or toolbox is opened, and in that case it's not possible for a field editor to be open. The escape shortcut in core is the one that closes chaff generally (e.g. when field editors are open) and that one does not have this precondition, so it can still be used to close field editors.