-
Notifications
You must be signed in to change notification settings - Fork 273
Upgrade all packages to the latest version #2430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Upgrade all packages to the latest version #2430
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Summary by CodeRabbit
WalkthroughThe Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (1)
package.json
(2 hunks)
🧰 Additional context used
🪛 GitHub Actions: Tests
package.json
[error] 1-1: The engine "node" is incompatible with this module. Expected version "22.16.0" but got "22.10.0".
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (5)
package.json (5)
44-45
: Dependencies upgraded:rate-limiter-flexible
→ 7.1.1,winston
→ 3.17.0. Versions align with the PR objective of using the latest stable releases.
49-55
: DevDependencies: Type definitions & ESLint parser updated: bumped@types/config
,@types/jest
,@types/mocha
,@types/node
, and@typescript-eslint/parser
. Ensure that type-checking and linting remain error-free after these upgrades.
68-75
: DevDependencies: Testing & tooling versions bumped: upgradedfirebase-tools
,mocha
,nodemon
,nyc
, andsinon
. Please run the full test suite (yarn test
) and development scripts (yarn dev
) to confirm there are no regressions.
78-78
: TypeScript upgraded to 5.8.3. Verify that the project compiles cleanly (yarn tsc
) and that any new TypeScript rules or features don’t introduce errors.
87-88
: Volta configuration updated: pinned Node v22.16.0 and Yarn v1.22.22 to match theengines
requirement, ensuring consistency across developer environments.
abfd336
to
0000eac
Compare
0000eac
to
96a48a6
Compare
99f78ed
to
5cf9f12
Compare
package.json
Outdated
"newrelic": "11.19.0", | ||
"nodemailer": "^6.9.15", | ||
"nodemailer-mock": "^2.0.6", | ||
"nodemailer": "6.7.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this downgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it by mistake.
It's fixed.
Thanks
pending: false, | ||
premium_since: null, | ||
// eslint-disable-next-line no-loss-of-precision | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we also remove these empty lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
test/unit/models/recruiters.test.js
Outdated
* It gives linting errors in testing the DB data with keys from fixtures | ||
*/ | ||
/* eslint-disable security/detect-object-injection */ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also remove the line no.2 and 3 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
0f84d5e
to
907f3cd
Compare
907f3cd
to
0291e5c
Compare
Date: 24 Mar, 2025
Developer Name: Suraj Maity ( @surajmaity1 )
Issue Ticket Number
Description
This PR addresses the issue of outdated dependencies as described in the linked GitHub issue. All packages have been updated to their latest stable versions.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Test Coverage
Screenshot 1
Additional Notes