Skip to content

Conversation

tclose
Copy link
Collaborator

@tclose tclose commented Sep 2, 2025

Added 'arch' optional arg to miniconda template to enable the specification of non x86 binaries.

Without this option it isn't possible to build docker images with miniconda on ARM systems.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @tclose, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the miniconda template by adding a configurable architecture parameter. This improvement allows users to specify the target CPU architecture for miniconda installations, moving beyond the previously hardcoded x86_64, thereby supporting a wider range of systems and binary types.

Highlights

  • Miniconda Template Enhancement: Introduced an optional 'arch' argument to the miniconda template.
  • Architecture Flexibility: Enables the specification of non-x86 binaries for miniconda installations, supporting diverse system architectures.
  • Default Architecture: The 'arch' argument defaults to 'x86_64' if not explicitly provided.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an optional arch argument to the miniconda template, allowing users to specify the architecture for the miniconda binaries. The change is well-implemented and maintains backward compatibility by defaulting to x86_64. My review includes a suggestion to improve the maintainability and robustness of the download URLs in the template.

Comment on lines +8 to +9
latest: https://repo.continuum.io/miniconda/Miniconda3-{{ self.version }}-Linux-{{ self.arch }}.sh
'*': https://repo.continuum.io/miniconda/Miniconda3-{{ self.version }}-Linux-{{ self.arch }}.sh

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The URLs for latest and * are identical. To improve maintainability and avoid duplication, you can use a YAML anchor.

Additionally, the repo.continuum.io domain redirects to repo.anaconda.com. It's better to use the canonical domain to avoid potential issues if the redirect is removed in the future.

        latest: &miniconda_url https://repo.anaconda.com/miniconda/Miniconda3-{{ self.version }}-Linux-{{ self.arch }}.sh
        '*': *miniconda_url

@tclose tclose added bug release to trigger release from pr patch patch tag for release conda labels Sep 2, 2025
@tclose
Copy link
Collaborator Author

tclose commented Sep 2, 2025

I'm not sure why those tests are failing, it doesn't appear to be related to my changes. Anyone have any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug conda patch patch tag for release release to trigger release from pr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant