Skip to content

Add 'arch' optional arg to miniconda template #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add 'arch' optional arg to miniconda template #686

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2bc4f28
added 'arch' optional arg to miniconda template to enable the specifi…
tclose Sep 2, 2025
edd2b62
fixing up type annotations for mypy
tclose Sep 2, 2025
9c8fa88
ignoring mypy errors in private click parser
tclose Sep 2, 2025
ccc604a
formatting changes for precommit compliance
tclose Sep 2, 2025
06ba8cb
Removed vscode settings and added .vscode to .gitignore
tclose Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions neurodocker/templates/miniconda.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ name: miniconda
url: https://docs.conda.io/projects/miniconda/en/latest/
binaries:
urls:
latest: https://repo.continuum.io/miniconda/Miniconda3-{{ self.version }}-Linux-x86_64.sh
'*': https://repo.continuum.io/miniconda/Miniconda3-{{ self.version }}-Linux-x86_64.sh
latest: https://repo.continuum.io/miniconda/Miniconda3-{{ self.version }}-Linux-{{ self.arch }}.sh
'*': https://repo.continuum.io/miniconda/Miniconda3-{{ self.version }}-Linux-{{ self.arch }}.sh
Comment on lines +8 to +9
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The URLs for latest and * are identical. To improve maintainability and avoid duplication, you can use a YAML anchor.

Additionally, the repo.continuum.io domain redirects to repo.anaconda.com. It's better to use the canonical domain to avoid potential issues if the redirect is removed in the future.

        latest: &miniconda_url https://repo.anaconda.com/miniconda/Miniconda3-{{ self.version }}-Linux-{{ self.arch }}.sh
        '*': *miniconda_url

env:
CONDA_DIR: '{{ self.install_path }}'
PATH: '{{ self.install_path }}/bin:$PATH'
Expand Down Expand Up @@ -34,6 +34,7 @@ binaries:
pip_opts: ''
yaml_file: ''
mamba: 'false'
arch: 'x86_64'
instructions: |
{% if not self.installed.lower() in ["true", "y", "1"] -%}
{{ self.install_dependencies() }}
Expand Down
Loading