Support arm64 arch for ROS2 Rolling #1130
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for arm64 architecture in the Linux build and test workflow.
- Introduces a new matrix entry for arm64 with a dedicated runner (ubuntu-version "latest-arm64") and limits node version to 20.X for arm64.
- Updates the Node.js setup step and coveralls flag to include the architecture in their labels for clarity.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the arm64 architecture in the Linux build and test workflow. Key changes include:
- Parameterizing the Ubuntu version using matrix variables.
- Introducing a matrix include for arm64 with a conditional check.
- Updating steps to reflect architecture-specific configurations.
| - architecture: arm64 | ||
| node-version: 22.X | ||
| ubuntu-version: 24.04-arm | ||
| condition: ${{ contains(github.ref, 'develop') }} |
There was a problem hiding this comment.
The 'condition' property within the matrix include is not a standard GitHub Actions feature; consider moving this check to an 'if:' condition at the job or step level to ensure it is correctly applied.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for arm64 architecture to the Linux build-and-test workflow.
- Updated the runs-on parameter and job condition to accommodate running on different Ubuntu versions and architectures.
- Extended the matrix configuration to include arm64 builds with specific Node.js and Ubuntu version selections.
Comments suppressed due to low confidence (1)
.github/workflows/linux-build-and-test.yml:43
- Verify that the 'ubuntu-24.04-arm' label is a valid GitHub Actions runner identifier for arm64 builds, ensuring consistency with the naming conventions used in the workflow.
ubuntu-version: 24.04-arm
| needs: identify-ros-distro | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-${{ matrix.ubuntu-version }} | ||
| if: ${{ matrix.architecture == 'x64' || contains(github.ref, 'develop') }} |
There was a problem hiding this comment.
Consider adding a comment to explain that the arm64 jobs are gated to run only on develop branches to improve maintainability and clarify the intended behavior.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the arm64 architecture in the Linux build and test workflow. Key changes include:
- Parameterized the "runs-on" configuration to use an Ubuntu version from the matrix.
- Introduced a new matrix for "architecture" with an include block for arm64 support.
- Updated Node.js setup and coveralls flag names to include the architecture.
| - architecture: arm64 | ||
| node-version: 22.X | ||
| ubuntu-version: 24.04-arm | ||
| exclude: ${{ !contains(github.ref, 'develop') }} |
There was a problem hiding this comment.
[nitpick] Consider adding a comment explaining why arm64 jobs are excluded when the branch does not contain 'develop', to improve clarity and maintainability.
minggangw
changed the title
2 participants
This PR adds support for the arm64 architecture in the Linux build and test workflow. Key changes include:
Fix: #1131