Skip to content

Support arm64 arch for ROS2 Rolling #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 16, 2025
Merged

Support arm64 arch for ROS2 Rolling #1130

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
024ca5d
Support arm64 arch
minggangw May 16, 2025
dc72e58
Change runner name
minggangw May 16, 2025
38174c3
Only run ubuntu-24.04-arm for rolling
minggangw May 16, 2025
f37539b
Address comments
minggangw May 16, 2025
d89b913
Use exclude in matrix
minggangw May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .github/workflows/linux-build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,27 @@ jobs:

build:
needs: identify-ros-distro
runs-on: ubuntu-latest
runs-on: ubuntu-${{ matrix.ubuntu-version }}
container:
image: ${{ needs.identify-ros-distro.outputs.linuxos }}
strategy:
fail-fast: false
matrix:
node-version: [20.X, 22.X, 24.X]
architecture: [x64]
ubuntu-version: [latest]
# Add arm64 support for rolling.
include:
- architecture: arm64
node-version: 22.X
ubuntu-version: 24.04-arm
condition: ${{ contains(github.ref, 'develop') }}
Copy link

Copilot AI May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'condition' property within the matrix include is not a standard GitHub Actions feature; consider moving this check to an 'if:' condition at the job or step level to ensure it is correctly applied.

Copilot uses AI. Check for mistakes.
steps:
- name: Setup Node.js ${{ matrix.node-version }}
- name: Setup Node.js ${{ matrix.node-version }} on ${{ matrix.architecture }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
architecture: ${{ matrix.architecture }}

- name: Setup ROS2
uses: ros-tooling/[email protected]
Expand All @@ -53,6 +62,7 @@ jobs:

- name: Build and test rclnodejs
run: |
uname -a
source /opt/ros/${{ needs.identify-ros-distro.outputs.distro }}/setup.bash
npm i
npm run lint
Expand All @@ -63,7 +73,7 @@ jobs:
uses: coverallsapp/github-action@v2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
flag-name: run-${{ matrix.node-version}}
flag-name: run-${{ matrix.node-version }}-${{ matrix.architecture }}
parallel: true

finish:
Expand Down
Loading