fix: add url_path parameter in rosbridge_websocket_launch.xml (backport of #963)#1011
Merged
bjsowa merged 1 commit intoRobotWebTools:humblefrom Feb 16, 2025
seanpai96:humble
Merged
fix: add url_path parameter in rosbridge_websocket_launch.xml (backport of #963)#1011bjsowa merged 1 commit intoRobotWebTools:humblefrom seanpai96:humble
bjsowa merged 1 commit intoRobotWebTools:humblefrom
seanpai96:humble
Conversation
bjsowa
approved these changes
Feb 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
Added
url_pathparameter in rosbridge_websocket_launch.xml.Description
The ‵url_path‵ parameter is missing in the
ros2 launchXML file, though it can be used inros2 run.This fix was previously PR'd in the
ros2branch, now backported tohumble.Use case:
The client should connect to
ws://<ip>/wswithout problem.Thanks!