Fix SearchPanes

[HamishSlater]

Fixes #910

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Project coverage is 45.38%. Comparing base (24aebd0) to head (82c76cb).

Files with missing lines	Patch %	Lines
formats/datatables/SearchPanes.php	0.00%	51 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #942      +/-   ##
============================================
- Coverage     45.39%   45.38%   -0.01%     
  Complexity     2326     2326              
============================================
  Files            80       80              
  Lines          9078     9080       +2     
============================================
  Hits           4121     4121              
- Misses         4957     4959       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[JeroenDeDauw]

Need to verify the old version did not have escaping OR that the new version is fine without it

[alistair3149]

I am not familiar with the existing implementation of the database query, so I am deferring to @thomas-topway-it to take a look 🙏

[thomas-topway-it]

I'm sorry, for some reason this escaped me, I will check it as soon as possible

[HamishSlater]

No worries
Sorry for the noise
I created another PR and accidentally overwrote this one
(forgot to create a feature branch)

[thomas-topway-it]

@HamishSlater I'm sorry for the delay.
I see the rationale of all that, indeed the queries were not optimal and I think your changes make queries more clear (by having plain SQL) so that in a further pull request they can be rewritten using the MW query builder properly.
Can you please fix the PHPCS errors and post an example of a different output (using selectSQLText) between the current set of queries and your changes ?
thanks a lot

[thomas-topway-it]

see comment

[HamishSlater]

wgDebugDumpSql

!$isCategory

{{#ask:[[Modification date::+]]
|?Modification date#-F[Y] = Year
|?Modification date#-F[m] = Month
|?Modification date#-F[d] = Day
|format=datatables
|datatables-searchPanes=true
}}

before
Edit: cache.. error throws before query

after

[rdbms] SRF\DataTables\SearchPanes::getPanesOptions [0.492ms] database: SELECT COUNT(*) as count FROM `smw_object_ids` AS t0 INNER JOIN `smw_fpt_mdat` AS t1 ON t0.smw_id=t1.s_id LIMIT 1
[rdbms] SRF\DataTables\SearchPanes::getPanesOptions [0.427ms] database: SELECT t1.o_serialized,COUNT( t1.o_serialized ) as count FROM `smw_object_ids` AS t0 INNER JOIN `smw_fpt_mdat` AS t1 ON t0.smw_id=t1.s_id GROUP BY t1.o_serialized HAVING count >= 1 ORDER BY count DESC, t1.o_serialized ASC LIMIT 146

$isCategory

{{#ask:[[Modification date::+]]
|?Modification date#-F[Y] = Year
|?Modification date#-F[m] = Month
|?Modification date#-F[d] = Day
|?Category = Test
|format=datatables
|datatables-searchPanes=true
}}

before
Edit: cache.. error throws before query

after

[rdbms] SRF\DataTables\SearchPanes::getPanesOptions [0.397ms] database: SELECT COUNT(*) as count FROM `smw_object_ids` AS t0 INNER JOIN `smw_fpt_mdat` AS t1 ON t0.smw_id=t1.s_id LIMIT 1
[rdbms] SRF\DataTables\SearchPanes::getPanesOptions [0.326ms] database: SELECT t1.o_serialized,COUNT( t1.o_serialized ) as count FROM `smw_object_ids` AS t0 INNER JOIN `smw_fpt_mdat` AS t1 ON t0.smw_id=t1.s_id GROUP BY t1.o_serialized HAVING count >= 1 ORDER BY count DESC, t1.o_serialized ASC LIMIT 146

[thomas-topway-it]

@HamishSlater thank you, for some reason I haven't seen this before. So for you selectSQLText does not work at all with the existing version and the posted wikitext ?

[HamishSlater]

I believe this has been fixed upstream in SemanticMediaWiki
SemanticMediaWiki/SemanticMediaWiki@600f520
Will be in 6.0.0 release