-
Notifications
You must be signed in to change notification settings - Fork 40
Switch to nonmonotone linesearch #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This change is part of the following stack: Change managed by git-spice. |
8678f9a to
e30fd08
Compare
c3bc889 to
13d0caf
Compare
1a2e08d to
385f2de
Compare
13d0caf to
1217df0
Compare
385f2de to
99bc5ce
Compare
1217df0 to
958c3b1
Compare
c702d3b to
0e603c4
Compare
febc812 to
4d2671f
Compare
0e603c4 to
edfdc97
Compare
a2b2e0e to
40b0baa
Compare
dd457e3 to
d88e2a5
Compare
6b2dcc0 to
c089f5b
Compare
examples: python: change HistoryCallback() calls test_constrained_dynamics : no use for HistoryCallback() here. fix ur5_reach.py
quadrotor_obstacles: Add separate mu_init for non-bound constrained setting
- decide labels automatically - only add "AL iters" label when there are 2 iters - get legend first before adding other labels [examples] re-tune some problems, plot convergence update solo_jump.py + greatly increase joint-space weight + add spinning + flight phase target irrelevant + spin further, fix landing fn
…nv from model with projectile's nq, nv ur10_ballistic : load_projectile_model() can take free flyer or not + adjust rigid constraint model factory, pass contact type
c089f5b to
07ea041
Compare
…lter linesearch using enum + variant Add header aligator/overloads.hpp (for overloaded lambda visitor pattern)
remove fallback for SA_LINESEARCH in Python
Member
Author
|
This PR is finally ready for review. |
edantec
reviewed
Dec 9, 2024
Collaborator
edantec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few questions but otherwise the PR seems ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to the nonmonotone linesearch
small tweak of ur10_ballistic
acrobot: change default params
HistoryCallback: pass solver pointer as argument to templated ctor
examples: python: change HistoryCallback() calls
re-tune cartpole.py
update quadrotor_obstacles.py
Add separate mu_init for non-bound constrained setting
[utils/plotting] some enhancements to plotting convergence diagrams
[examples] re-tune some problems, plot convergence
Update plotting.py again:
update solo_jump.py
solo_jump : greatly increase joint-space weight
solo_jump : add spinning
solo_jump : flight phase target irrelevant
solo_jump : spin further, fix landing fn
ur10_ballistic : load_projectile_model() can take free flyer or not
[examples] ur10_ballistic.py : sanely distinguish original model nq, nv from model with projectile's nq, nv
plotting.py : get legend first before adding other labels
ask for tighter tolerance on cartpole
quadrotor_obstacles : use the plotting util