Skip to content

Small fixes for pixi run build and tracy integrations #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ManifoldFR merged 17 commits into from
Nov 13, 2025
Merged

Small fixes for pixi run build and tracy integrations #375

ManifoldFR merged 17 commits into from
Nov 13, 2025

Conversation

@EtienneAr
Copy link
Contributor

@EtienneAr EtienneAr commented Nov 13, 2025

  • Adding the missing ninja dependency (and updating the lock file)
  • Update CMakeLists to better support Tracy
    • Aligator was not linking against Tracy
    • TRACY_ENABLE was never defined, which resulted in Tracy not being "activated"
  • Update pixi.toml to better support Tracy
    • Conda package renamed from tracy-client to tracy-profiler
    • Actually use the env variable ALIGATOR_TRACY_ENABLE to actually set cmake flags

@EtienneAr EtienneAr requested a review from ManifoldFR November 13, 2025 13:43
ManifoldFR
ManifoldFR reviewed Nov 13, 2025
View reviewed changes
Copy link
Member

@ManifoldFR ManifoldFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @EtienneAr. I've asked @jorisv for additional feedback on stuff I'm not sure of.

@ManifoldFR ManifoldFR added this to the aligator 1.0 milestone Nov 13, 2025
jorisv
jorisv requested changes Nov 13, 2025
View reviewed changes
EtienneAr and others added 17 commits November 13, 2025 21:53
@EtienneAr @ManifoldFR
Add missing ninja dependency
8a85b26
@EtienneAr @ManifoldFR
Update tracy dependency - conda-forge name changes
5178d5a
@EtienneAr @ManifoldFR
Actuallyuse ALIGATOR_TRACY_ENABLE env var to set cmake flag
4929dd5
@EtienneAr @ManifoldFR
Factorize Tracy cmakelists code
336a7d3
@EtienneAr @ManifoldFR
Fix linking against tracy
4569557
@EtienneAr @ManifoldFR
Add compile definition to actually enable tracy when needed
08096ea
@EtienneAr @ManifoldFR
Update lock file after adding ninja
79eaed6
@EtienneAr @ManifoldFR
Update changelog
0bb4bc2
@EtienneAr @ManifoldFR
Run pre-commit
07798ff
@EtienneAr @ManifoldFR
Disable tracy when making releases
3da4e59
@EtienneAr @ManifoldFR
Restrict dependency to only subpackage tracy-profiler-client
b21d5c7
@EtienneAr @ManifoldFR
Fix cmakelists.txt: works with tracy froù conda and fetchcontact
51c30d0
@EtienneAr @ManifoldFR
Give tracy_enable a default value in activation.sh
e39969e
@EtienneAr @jorisv @ManifoldFR
Update CMakeLists.txt
c729891 
Co-authored-by: Joris Vaillant <[email protected]>
@EtienneAr @ManifoldFR
Add PR link in changelog
58f402b
@EtienneAr @ManifoldFR
Remove unecessary CMAKE_PREFIX_PATH for pixi build
5444146
@EtienneAr @ManifoldFR
Remove deifnition TRACY_ENABLE: already done by target Tracy::TracyCl…
b01d7ea 
…ient
@ManifoldFR ManifoldFR enabled auto-merge November 13, 2025 20:53
@ManifoldFR ManifoldFR merged commit e326eaf into Simple-Robotics:main Nov 13, 2025
18 of 19 checks passed
@EtienneAr EtienneAr deleted the fix_pixi_build branch November 13, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ManifoldFR ManifoldFR ManifoldFR left review comments

@jorisv jorisv jorisv approved these changes

+1 more reviewer

@LouiseMsn LouiseMsn LouiseMsn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@EtienneAr EtienneAr

Labels

no changelog

Projects

None yet

Milestone

aligator 1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@EtienneAr @jorisv @ManifoldFR @LouiseMsn