-
Notifications
You must be signed in to change notification settings - Fork 7
Add Inverse dynamics class using TSID #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR is (almost) ready for review. The only thing left is to wait for a new release of TSID (hopefully coming soon) in order to have the fix I made regarding adding and removing rigid contacts. Here is a overview of the proposed changes :
|
edantec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First draft of review, pointing some mistakes (mainly wrong signedness for int)
Also pointing bugs in test and examples
This PR is still in progress, here is my todo list before asking for any review. Skip this comment to have a clearer summary of this PR.
setTarget,solve) should be templated on the vector type, and useconst Eigen::Ref<VectorType> &sampleBase,samplePostureandposeBasedo not require to be kept as member variablefoot_forcesshould be better typed than a flattened list, probablyMatrixtype<3, -1>Should interpolator be templated to account for matrices now ?RobotModelHandlershould avec methods to extract confguration and velocity from the stategetConfigurationgetVelocityDo a global search of.head(nq).tail(nv)and replace when appropriateUpdateInternalDataKinodynamicsID,KinodynamidsID::SettingsgetFootPoseShould the data handler keep a copy of the state ?(for later PR)getFootPoseshould take the foot index as argument, not the name (more effcient solution by default)ID should also give the q and v after interpollation, to feed forward to the robot(returns acceleration already, for later PR)Add Angular Momentum task--> Not needed for now (maybe for centroidal)Which sample value & derivative to set ?Add unit testDouble check that Com task value, derivative is good--> Not needed for now (maybe for centroidal)How to test derivative (in unittests ?) -> Speed of convergence ??Compute task second derivative ?? --> is it worth ? Test it !