Skip to content

Conversation

@Panaetius
Copy link
Member

@Panaetius Panaetius commented Jul 26, 2024

moves user_preferences over to users namespace.
Also moves table to users schema, migrating old preferences and deleting the user_preferences db schema.

part of addressing #304

@Panaetius
Copy link
Member Author

Panaetius commented Jul 26, 2024

@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch 2 times, most recently from 8dc8828 to bfee22a Compare July 26, 2024 14:03
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch 2 times, most recently from ede3677 to d9750c4 Compare August 5, 2024 08:28
@Panaetius Panaetius changed the base branch from main to fix-schemathesis-query-tests August 6, 2024 06:47
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch from d9750c4 to 8422891 Compare August 6, 2024 06:47
@Panaetius Panaetius force-pushed the fix-schemathesis-query-tests branch from 1852d63 to 6bc4067 Compare August 6, 2024 06:54
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch from 8422891 to 7134c00 Compare August 6, 2024 06:54
@Panaetius Panaetius force-pushed the fix-schemathesis-query-tests branch from 6bc4067 to 8216c90 Compare August 6, 2024 08:54
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch from 7134c00 to e8177cf Compare August 6, 2024 08:55
@Panaetius Panaetius force-pushed the fix-schemathesis-query-tests branch from 8216c90 to aac586b Compare August 6, 2024 09:25
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch 3 times, most recently from 53c6594 to ad7899f Compare August 6, 2024 11:12
@Panaetius Panaetius marked this pull request as ready for review August 6, 2024 11:17
@Panaetius Panaetius requested a review from a team as a code owner August 6, 2024 11:17
@Panaetius Panaetius force-pushed the fix-schemathesis-query-tests branch from aac586b to 4c6c845 Compare August 7, 2024 08:25
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch from ad7899f to 8ba09c5 Compare August 7, 2024 08:25
@Panaetius Panaetius force-pushed the fix-schemathesis-query-tests branch from 4c6c845 to 3816628 Compare August 7, 2024 08:41
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch from 8ba09c5 to ef11fb3 Compare August 7, 2024 08:41
olevski
olevski previously approved these changes Aug 7, 2024
Base automatically changed from fix-schemathesis-query-tests to main August 7, 2024 10:11
@Panaetius Panaetius dismissed olevski’s stale review August 7, 2024 10:11

The base branch was changed.

@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch from ef11fb3 to 2bc2ff5 Compare August 7, 2024 12:53
@olevski olevski self-requested a review August 7, 2024 12:59
@Panaetius Panaetius enabled auto-merge (squash) August 7, 2024 13:00
@Panaetius Panaetius merged commit 278aedc into main Aug 7, 2024
5 checks passed
@Panaetius Panaetius deleted the refactor/304-unify-users-preferences branch August 7, 2024 13:20
@coveralls
Copy link

coveralls commented Aug 7, 2024

Pull Request Test Coverage Report for Build 10284691819

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 154 of 160 (96.25%) changed or added relevant lines in 9 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.07%) to 90.398%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/users/db.py 54 56 96.43%
components/renku_data_services/migrations/versions/17eea03f938e_move_user_preferences_to_user_schema.py 23 27 85.19%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_api/auth.py 1 89.61%
components/renku_data_services/crc/blueprints.py 1 93.63%
components/renku_data_services/crc/models.py 1 84.91%
components/renku_data_services/crc/db.py 2 87.58%
Totals Coverage Status
Change from base Build 10282377659: -0.07%
Covered Lines: 9038
Relevant Lines: 9998

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants