Skip to content

Conversation

@Panaetius
Copy link
Member

adds validation of ids and responses to crc, user and secret endpoints.
handles response validation errors correctly
part of #304

@Panaetius
Copy link
Member Author

Panaetius commented Jul 26, 2024

@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from 41e725e to 7dbfa1f Compare July 26, 2024 15:30
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from 7dbfa1f to 097e40b Compare August 5, 2024 08:10
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch 2 times, most recently from ede3677 to d9750c4 Compare August 5, 2024 08:28
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from 097e40b to 88b4e38 Compare August 5, 2024 08:28
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch from d9750c4 to 8422891 Compare August 6, 2024 06:47
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from 88b4e38 to 5617859 Compare August 6, 2024 06:47
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch from 8422891 to 7134c00 Compare August 6, 2024 06:54
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from 5617859 to 32a0650 Compare August 6, 2024 06:54
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch from 7134c00 to e8177cf Compare August 6, 2024 08:55
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from 32a0650 to 0eeeed9 Compare August 6, 2024 08:55
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch from e8177cf to 120ce02 Compare August 6, 2024 09:25
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from 0eeeed9 to 8960dd7 Compare August 6, 2024 09:25
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch from 120ce02 to 53c6594 Compare August 6, 2024 09:59
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from 8960dd7 to 6912087 Compare August 6, 2024 09:59
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch from 53c6594 to ad7899f Compare August 6, 2024 11:12
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch 2 times, most recently from d3c73c4 to 7f5058b Compare August 6, 2024 12:50
@Panaetius Panaetius marked this pull request as ready for review August 6, 2024 12:50
@Panaetius Panaetius requested a review from a team as a code owner August 6, 2024 12:50
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from 7f5058b to 3f004bf Compare August 7, 2024 07:16
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch from ad7899f to 8ba09c5 Compare August 7, 2024 08:25
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from 3f004bf to f43c168 Compare August 7, 2024 08:25
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch from 8ba09c5 to ef11fb3 Compare August 7, 2024 08:41
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from f43c168 to 58417b0 Compare August 7, 2024 08:41
olevski
olevski previously approved these changes Aug 7, 2024
@Panaetius Panaetius force-pushed the refactor/304-unify-users-preferences branch from ef11fb3 to 2bc2ff5 Compare August 7, 2024 12:53
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from 58417b0 to bd2b8e3 Compare August 7, 2024 12:53
Base automatically changed from refactor/304-unify-users-preferences to main August 7, 2024 13:19
@Panaetius Panaetius dismissed olevski’s stale review August 7, 2024 13:19

The base branch was changed.

@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from bd2b8e3 to b0a6da0 Compare August 7, 2024 13:24
@Panaetius Panaetius requested a review from olevski August 7, 2024 13:24
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10285214866

Details

  • 52 of 57 (91.23%) changed or added relevant lines in 6 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.003%) to 90.395%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/crc/blueprints.py 23 28 82.14%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/crc/blueprints.py 1 92.88%
components/renku_data_services/crc/db.py 2 87.58%
components/renku_data_services/storage/blueprints.py 3 94.65%
Totals Coverage Status
Change from base Build 10285141847: -0.003%
Covered Lines: 9054
Relevant Lines: 10016

💛 - Coveralls

@Panaetius Panaetius merged commit a896c9d into main Aug 12, 2024
5 checks passed
@Panaetius Panaetius deleted the refactor-add-validation-to-crc branch August 12, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants