fix: correct assignment of single bit read-only storage-less fields#33
Merged
darsor merged 2 commits intoSystemRDL:mainfrom Dec 28, 2025
Merged
Conversation
fix single-bit read-only storage-less fields (SystemRDL#32) fix read/write buffering in arrays of regfiles (SystemRDL#31)
8c766df to
6ff7f80
Compare
Member
|
Thanks for the PR. I changed the logic a bit to handle the constant case a little more explicitly, then updated the unit tests to ensure single-bit fields work for all field types (combinations of hw/sw access attributes). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes #32
I'm unsure if the condition that the branch is now checking is quite sufficient, so if there is any changes you would like to it please let me know. My understanding of the systemrdl spec is that there is only 3 different ways a field can be implemented, either as a storage element, as continuously assigned from hardware, or a constant. This branch should now run for both the storage element and the constant cases here, with the continuously assigned case already handled in the branch above it.
Checklist