Skip to content

fix: correct assignment of single bit read-only storage-less fields#33

Merged
darsor merged 2 commits intoSystemRDL:mainfrom
calebfletcher:fix-ro-singlebit-storageless
Dec 28, 2025
Merged

fix: correct assignment of single bit read-only storage-less fields#33
darsor merged 2 commits intoSystemRDL:mainfrom
calebfletcher:fix-ro-singlebit-storageless

Conversation

@calebfletcher
Copy link

Description of change

Fixes #32

I'm unsure if the condition that the branch is now checking is quite sufficient, so if there is any changes you would like to it please let me know. My understanding of the systemrdl spec is that there is only 3 different ways a field can be implemented, either as a storage element, as continuously assigned from hardware, or a constant. This branch should now run for both the storage element and the constant cases here, with the continuously assigned case already handled in the branch above it.

Checklist

  • I have reviewed this project's contribution guidelines
  • This change has been tested and does not break any of the existing unit tests. (if unable to run the tests, let us know)
  • If this change adds new features, I have added new unit tests that cover them.

calebfletcher and others added 2 commits December 28, 2025 00:33
fix single-bit read-only storage-less fields (SystemRDL#32)

fix read/write buffering in arrays of regfiles (SystemRDL#31)
@darsor darsor force-pushed the fix-ro-singlebit-storageless branch from 8c766df to 6ff7f80 Compare December 28, 2025 00:54
@darsor
Copy link
Member

darsor commented Dec 28, 2025

Thanks for the PR. I changed the logic a bit to handle the constant case a little more explicitly, then updated the unit tests to ensure single-bit fields work for all field types (combinations of hw/sw access attributes).

@darsor darsor merged commit 23a2ce3 into SystemRDL:main Dec 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Type assignment error for constant single-bit fields

2 participants