Skip to content

Conversation

@maxy-shpfy
Copy link
Collaborator

@maxy-shpfy maxy-shpfy commented Jan 13, 2026

Description

Closes https://github.com/Shopify/oasis-frontend/issues/421

Enhanced the "Copy from Run" functionality in the SubmitTaskArgumentsDialog component to allow users to copy arguments from a specific run by entering a run ID directly. This improves workflow efficiency by providing an alternative to selecting from the recent runs list.

Type of Change

  • New feature
  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Test Instructions

Screen Recording 2026-01-12 at 6.41.59 PM.mov (uploaded via Graphite)

  1. Open the task submission dialog
  2. Click on "Copy from Run"
  3. Test entering a valid run ID in the new input field and verify arguments are copied
  4. Test entering an invalid run ID and verify error handling
  5. Verify that selecting from recent runs still works as before
  6. Confirm that copied arguments are merged with existing ones rather than replacing them completely

Additional Comments

The implementation now merges copied arguments with existing ones instead of replacing them entirely, preserving any manually entered values that aren't being overwritten.

Copy link
Collaborator Author

@maxy-shpfy maxy-shpfy marked this pull request as ready for review January 13, 2026 02:43
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner January 13, 2026 02:43
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_pipeline_arguments_from_custom_run_id branch from 1078bcd to d4fa437 Compare January 13, 2026 02:48
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch from 10479d0 to a5d0cd3 Compare January 13, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants