Skip to content

bugfix(selection): Prevent exploits from grouping structures and units #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2025
Merged

bugfix(selection): Prevent exploits from grouping structures and units #1347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Generals/Code/GameEngine/Source/GameClient/MessageStream/SelectionXlat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,6 +1141,13 @@ GameMessageDisposition SelectionTranslator::translateGameMessage(const GameMessa
{
VecObjectPtr objlist = selectedSquad->getLiveObjects();
Int numObjs = objlist.size();

// TheSuperHackers @bugfix skyaero 22/07/2025 Can't select other units if you have a structure selected. So deselect the structure to prevent group force attack exploit.
if (numObjs > 0 && objlist[0]->getDrawable()->isKindOf(KINDOF_STRUCTURE))
{
TheInGameUI->deselectAllDrawables();
}

for (Int i = 0; i < numObjs; ++i)
{
TheInGameUI->selectDrawable(objlist[i]->getDrawable());
Expand Down
7 changes: 7 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/GameClient/MessageStream/SelectionXlat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,6 +1216,13 @@ GameMessageDisposition SelectionTranslator::translateGameMessage(const GameMessa
{
VecObjectPtr objlist = selectedSquad->getLiveObjects();
Int numObjs = objlist.size();

// TheSuperHackers @bugfix skyaero 22/07/2025 Can't select other units if you have a structure selected. So deselect the structure to prevent group force attack exploit.
if (numObjs > 0 && objlist[0]->getDrawable()->isKindOf(KINDOF_STRUCTURE))
{
TheInGameUI->deselectAllDrawables();
}

for (Int i = 0; i < numObjs; ++i)
{
TheInGameUI->selectDrawable(objlist[i]->getDrawable());
Expand Down
Loading