-
Notifications
You must be signed in to change notification settings - Fork 140
chore(script): Add script to help move files to Core #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f9d295f to
7c7013d
Compare
7c7013d to
0499d17
Compare
Mauller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay overall, but you might want to check that the expected path structures exists before continuing.
it can be done using relative paths, so might want to check that the script is in the expected path first then check the gen and genmd ones.
https://www.geeksforgeeks.org/python/python-os-path-exists-method/
For what purpose? Moving files does have a recursive folder creation call with: os.makedirs(os.path.dirname(toPath), exist_ok=True)And if files to be moved or deleted do not exist, then the scripts throws errors by design, so we can see misconfiguration. A successful move should never fail. |
Mauller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay having had a look over it again.
This python script helps moving files for the unification effort.
Is now a separate change because it is a pain to base everything on the GameMemory unify change when that gets review comments.