Skip to content

Conversation

@xezon
Copy link

@xezon xezon commented Jul 31, 2025

This python script helps moving files for the unification effort.

Is now a separate change because it is a pain to base everything on the GameMemory unify change when that gets review comments.

Copy link

@Mauller Mauller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay overall, but you might want to check that the expected path structures exists before continuing.

it can be done using relative paths, so might want to check that the script is in the expected path first then check the gen and genmd ones.

https://www.geeksforgeeks.org/python/python-os-path-exists-method/

@xezon
Copy link
Author

xezon commented Aug 3, 2025

Looks okay overall, but you might want to check that the expected path structures exists before continuing.

it can be done using relative paths, so might want to check that the script is in the expected path first then check the gen and genmd ones.

https://www.geeksforgeeks.org/python/python-os-path-exists-method/

For what purpose? Moving files does have a recursive folder creation call with:

os.makedirs(os.path.dirname(toPath), exist_ok=True)

And if files to be moved or deleted do not exist, then the scripts throws errors by design, so we can see misconfiguration. A successful move should never fail.

Copy link

@Mauller Mauller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay having had a look over it again.

@xezon xezon changed the title chore(script): Add script to help unify and move files chore(script): Add script to help move files Aug 3, 2025
@xezon xezon changed the title chore(script): Add script to help move files chore(script): Add script to help move files to Core Aug 3, 2025
@xezon xezon merged commit abd1b90 into TheSuperHackers:main Aug 3, 2025
16 checks passed
@xezon xezon deleted the xezon/unify-script branch August 3, 2025 15:45
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ThisProject The issue was introduced by this project, or this task is specific to this project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants