tweak(string): Implement functions in AsciiString, UnicodeString to return the byte count of the contained string #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
reviewed
Aug 2, 2025
Mauller
force-pushed
the
feat-return-strings-bytecount
branch
from
c5e799d to
9a5de01
Compare
xezon
reviewed
Aug 2, 2025
There was a problem hiding this comment.
How about write this like
Return the number of bytes until the first zero character or end of string.
There was a problem hiding this comment.
How about write this like
Return the number of characters until the first zero character or end of string.
Unlike std::string::size, this strlen will stop at the first 0 character. It is a subtle difference.
… a contained string in bytes
Mauller
force-pushed
the
feat-return-strings-bytecount
branch
from
9a5de01 to
b8dbd3c
Compare
Author
|
Tweaked it now, comments should be a bit better based on feedback. |
xezon
approved these changes
Aug 3, 2025
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
I still do not like the function comments but it is ok.
xezon
added
the
Refactor
xezon
changed the title
xezon
removed
the
Refactor
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…eturn the byte count of the contained string (TheSuperHackers#1407)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR that simply adds functions to the string classes to return their size in bytes.