Skip to content

tweak(string): Implement functions in AsciiString, UnicodeString to return the byte count of the contained string #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 1 commit into from
Aug 3, 2025
Merged

tweak(string): Implement functions in AsciiString, UnicodeString to return the byte count of the contained string #1407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion Core/GameEngine/Include/Common/AsciiString.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,14 @@ class AsciiString
~AsciiString();

/**
Return the length, in characters (not bytes!), of the string.
Return the length, in characters, of the string up to the first zero or null terminator.
*/
int getLength() const;

/**
Return the number of bytes used by the string up to the first zero or null terminator.
*/
int getByteCount() const;
/**
Return true iff the length of the string is zero. Equivalent
to (getLength() == 0) but slightly more efficient.
Expand Down Expand Up @@ -391,6 +396,13 @@ inline int AsciiString::getLength() const
return m_data ? strlen(peek()) : 0;
}

// -----------------------------------------------------
inline int AsciiString::getByteCount() const
{
validate();
return m_data ? getLength() : 0;
}

// -----------------------------------------------------
inline Bool AsciiString::isEmpty() const
{
Expand Down
14 changes: 13 additions & 1 deletion Core/GameEngine/Include/Common/UnicodeString.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,14 @@ class UnicodeString
~UnicodeString();

/**
Return the length, in characters (not bytes!), of the string.
Return the length, in characters, of the string up to the first zero or null terminator.
*/
int getLength() const;

/**
Return the number of bytes used by the string up to the first zero or null terminator.
*/
int getByteCount() const;
/**
Return true iff the length of the string is zero. Equivalent
to (getLength() == 0) but slightly more efficient.
Expand Down Expand Up @@ -341,6 +346,13 @@ inline int UnicodeString::getLength() const
return m_data ? wcslen(peek()) : 0;
}

// -----------------------------------------------------
inline int UnicodeString::getByteCount() const
{
validate();
return m_data ? getLength() * sizeof(WideChar) : 0;
}

// -----------------------------------------------------
inline Bool UnicodeString::isEmpty() const
{
Expand Down
Loading