bugfix(scrolling): Fix vertical scroll speed bugs#1492
Merged
xezon merged 2 commits intoTheSuperHackers:mainfrom Sep 4, 2025
Merged
bugfix(scrolling): Fix vertical scroll speed bugs#1492xezon merged 2 commits intoTheSuperHackers:mainfrom
xezon merged 2 commits intoTheSuperHackers:mainfrom
Conversation
xezon
changed the title
34 tasks
Mauller
approved these changes
Sep 3, 2025
Mauller
left a comment
Mauller
left a comment
There was a problem hiding this comment.
Looks good and appears to work regardless of camera angle
xezon
added
Major
xezon
force-pushed
the
xezon/fix-vertical-scroll-speed
branch
from
a54714c to
19fead9
Compare
Author
|
Replicated to Generals without conflicts. |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the vertical scroll speed bugs.
The aspect ratio calculation is useless and the camera pitch must not be part of the view plane to scroll by, because that messes with the scroll speed.
TODO