bugfix(heightmap): Fix dynamic lights on terrain #2039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Bug
Skyaero42
reviewed
Dec 31, 2025
| // Updates the diffuse color values in the vertices as affected by the dynamic | ||
| // lights. | ||
| // TheSuperHackers @bugfix xezon 15/12/2025 The dynamic lights are now properly | ||
| // drawn on the entirety of the drawable map region. |
There was a problem hiding this comment.
I would suggest changing this to:
// TheSuperHackers @bugfix xezon 15/12/2025
// Fixed terrain dynamic lighting issues caused by incorrect coordinate bounds.
Author
There was a problem hiding this comment.
I don't see one better than the other. Historically we did not use past tense in comments.
There was a problem hiding this comment.
"Draw the dynamic lights properly on the entirety of the drawable map region." perhaps?
Skyaero42
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes fixes the dynamic lights on terrain. The coordinate bounds were incorrectly calculated, which caused dynamic lights to not draw at all within a viewed area or become stuck under some conditions.
Some vehicle types do not emit dynamic lights.
Fixed Dynamic Lights on Terrain