Skip to content

bugfix(heightmap): Fix dynamic lights on terrain #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 2 commits into from
Jan 2, 2026
Merged

bugfix(heightmap): Fix dynamic lights on terrain #2039

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
979f083
bugfix(heightmap): Fix dynamic lights on terrain
xezon Dec 31, 2025
c0e871a
Reword comment
xezon Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions Core/GameEngineDevice/Source/W3DDevice/GameClient/HeightMap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1387,7 +1387,10 @@ Int HeightMapRenderObjClass::initHeightData(Int x, Int y, WorldHeightMap *pMap,
//=============================================================================
// HeightMapRenderObjClass::On_Frame_Update
//=============================================================================
/** Updates the diffuse color values in the vertices as affected by the dynamic lights.*/
// Updates the diffuse color values in the vertices as affected by the dynamic
// lights.
// TheSuperHackers @bugfix xezon 15/12/2025 Now draws the dynamic lights
// properly on the entirety of the drawable map region.
//=============================================================================
void HeightMapRenderObjClass::On_Frame_Update(void)
{
Expand Down Expand Up @@ -1418,10 +1421,10 @@ void HeightMapRenderObjClass::On_Frame_Update(void)
Int numDynaLights=0;
W3DDynamicLight *enabledLights[MAX_ENABLED_DYNAMIC_LIGHTS];

Int yCoordMin = m_map->getDrawOrgY();
Int yCoordMax = m_y+m_map->getDrawOrgY();
Int xCoordMin = m_map->getDrawOrgX();
Int xCoordMax = m_x+m_map->getDrawOrgX();
const Int xCoordMin = m_map->getDrawOrgX() - m_map->getBorderSizeInline();
const Int yCoordMin = m_map->getDrawOrgY() - m_map->getBorderSizeInline();
const Int xCoordMax = xCoordMin + m_map->getDrawWidth();
const Int yCoordMax = yCoordMin + m_map->getDrawHeight();

for (pDynamicLightsIterator.First(); !pDynamicLightsIterator.Is_Done(); pDynamicLightsIterator.Next())
{
Expand Down
Loading