perf(weaponstore): Optimize WeaponStore::findWeaponTemplatePrivate with hash map lookup #2042
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
reviewed
Jan 1, 2026
xezon
added
Minor
Author
|
Adjusted according to the proposed changes. Needs review. |
xezon
reviewed
Jan 1, 2026
Author
|
Adjusted, that should be all. Awaiting finalization |
xezon
reviewed
Jan 2, 2026
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
Is still not right. Code needs to be replicated to Generals when done.
Author
|
Alright, changes above are addressed. Let me know if I need to open a new branch and recompile my commits. |
xezon
reviewed
Jan 2, 2026
xezon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.