feat: add replaceValue... methods to MutableSolutionView by triceo · Pull Request #2180 · TimefoldAI/timefold-solver

triceo · 2026-03-10T19:09:45Z

In addition to moveValue...

Copilot

Pull request overview

This PR optimizes moving and swapping elements inside planning list variables in MoveDirector, aiming to reduce per-move overhead on the solver hot path.

Changes:

Introduces a moveInList(...) helper that selects between Collections.rotate and remove+add based on move distance/position.
Updates moveValueInList(...) to use the new helper and return the moved value via the list after mutation.
Replaces manual swap logic with Collections.swap(...) in swapValuesInList(...).

core/src/main/java/ai/timefold/solver/core/impl/move/MoveDirector.java

Christopher-Chianelli

LGTM when tests are green.

core/src/main/java/ai/timefold/solver/core/impl/move/MoveDirector.java

triceo · 2026-03-11T08:27:10Z

@Christopher-Chianelli Since I was already here, I decided to implement a feature request from the models. Please re-review, new code was added.

@winklerm Was this what you had in mind?

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

core/src/main/java/ai/timefold/solver/core/impl/move/MoveDirector.java

core/src/main/java/ai/timefold/solver/core/preview/api/move/MutableSolutionView.java

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

core/src/main/java/ai/timefold/solver/core/impl/move/MoveDirector.java

core/src/main/java/ai/timefold/solver/core/preview/api/move/MutableSolutionView.java

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

core/src/main/java/ai/timefold/solver/core/preview/api/move/MutableSolutionView.java

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

core/src/main/java/ai/timefold/solver/core/preview/api/move/MutableSolutionView.java

…tableSolutionView.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

core/src/main/java/ai/timefold/solver/core/preview/api/move/MutableSolutionView.java

sonarqubecloud · 2026-03-11T10:54:49Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

winklerm · 2026-03-11T11:23:43Z

core/src/main/java/ai/timefold/solver/core/preview/api/move/MutableSolutionView.java

+     * while the sourceEntity's list size remains unchanged.
+     *
+     * @param variableMetaModel Describes the variable to be changed.
+     * @param sourceEntity The entity in which the value at {@code sourceIndex} will be replaced (overwritten).


Q: I would expect destinationEntity and destinationIndex instead of sourceEntity and sourceIndex, but might be just my personal preference.

winklerm · 2026-03-11T11:24:18Z

@winklerm Was this what you had in mind?

Yes, thank you very much!!

perf: improve value move within a list

7e69d2f

Copilot AI review requested due to automatic review settings March 10, 2026 19:09

triceo temporarily deployed to internal March 10, 2026 19:09 — with GitHub Actions Inactive

triceo requested a review from Christopher-Chianelli March 10, 2026 19:10

Copilot started reviewing on behalf of triceo March 10, 2026 19:10 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Christopher-Chianelli approved these changes Mar 10, 2026

View reviewed changes

core/src/main/java/ai/timefold/solver/core/impl/move/MoveDirector.java Outdated Show resolved Hide resolved

feat: introduce replace(...) operations to MutableSolutionView

e69ab2c

triceo temporarily deployed to internal March 11, 2026 08:25 — with GitHub Actions Inactive

triceo requested a review from Christopher-Chianelli March 11, 2026 08:26

triceo linked an issue Mar 11, 2026 that may be closed by this pull request

Feat: MutableSolutionView.replaceValue() #2181

Open

triceo added this to the v2.0.0 milestone Mar 11, 2026

triceo requested a review from Copilot March 11, 2026 08:29

Copilot started reviewing on behalf of triceo March 11, 2026 08:29 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

review

938e393

triceo temporarily deployed to internal March 11, 2026 09:21 — with GitHub Actions Inactive

triceo requested a review from Copilot March 11, 2026 09:36

Copilot started reviewing on behalf of triceo March 11, 2026 09:37 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

triceo temporarily deployed to internal March 11, 2026 10:12 — with GitHub Actions Inactive

Copilot AI review requested due to automatic review settings March 11, 2026 10:13

triceo force-pushed the smarter branch from 5cb0ccf to 4e5d168 Compare March 11, 2026 10:13

triceo temporarily deployed to internal March 11, 2026 10:14 — with GitHub Actions Inactive

review

d6b65ac

triceo force-pushed the smarter branch from 4e5d168 to d6b65ac Compare March 11, 2026 10:14

Copilot started reviewing on behalf of triceo March 11, 2026 10:14 View session

triceo temporarily deployed to internal March 11, 2026 10:14 — with GitHub Actions Inactive

Copilot AI reviewed Mar 11, 2026

View reviewed changes

core/src/main/java/ai/timefold/solver/core/preview/api/move/MutableSolutionView.java Show resolved Hide resolved

core/src/main/java/ai/timefold/solver/core/preview/api/move/MutableSolutionView.java Outdated Show resolved Hide resolved

triceo temporarily deployed to internal March 11, 2026 10:29 — with GitHub Actions Inactive

review

5cf6682

Copilot AI review requested due to automatic review settings March 11, 2026 10:31

triceo force-pushed the smarter branch from d1bfef8 to 5cf6682 Compare March 11, 2026 10:31

triceo temporarily deployed to internal March 11, 2026 10:31 — with GitHub Actions Inactive

Copilot started reviewing on behalf of triceo March 11, 2026 10:31 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

core/src/main/java/ai/timefold/solver/core/preview/api/move/MutableSolutionView.java Outdated Show resolved Hide resolved

Update core/src/main/java/ai/timefold/solver/core/preview/api/move/Mu…

632aee4

…tableSolutionView.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 11, 2026 10:36

triceo deployed to internal March 11, 2026 10:36 — with GitHub Actions Active

Copilot started reviewing on behalf of triceo March 11, 2026 10:37 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

core/src/main/java/ai/timefold/solver/core/preview/api/move/MutableSolutionView.java Show resolved Hide resolved

triceo changed the title ~~perf: improve value move within a list~~ feat: add replaceValue... methods to MutableSolutionView Mar 11, 2026

winklerm reviewed Mar 11, 2026

View reviewed changes

Conversation

triceo commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Christopher-Chianelli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

triceo commented Mar 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 11, 2026

Quality Gate passed

Uh oh!

winklerm Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

winklerm commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

triceo commented Mar 10, 2026 •

edited

Loading