Conversation
Blaok
reviewed
Jul 25, 2025
| try: | ||
| forward_applicable(new_ctx, compile_entry, kwargs) | ||
| succeeded.append(floorplan_file) | ||
| except Exception: |
Member
There was a problem hiding this comment.
Is there a more specific exception that needs to be caught? Generally it's not a good idea to catch all exceptions.
Ed-5100
force-pushed
the
yx388/dev
branch
4 times, most recently
from
b51d168 to
342572b
Compare
Blaok
reviewed
Jul 31, 2025
Ed-5100
force-pushed
the
yx388/dev
branch
7 times, most recently
from
359b0be to
79e6a05
Compare
Blaok
reviewed
Aug 14, 2025
tapa/graphir_conversion/add_iface.py
Outdated
Comment on lines
+336
to
+339
| updated_ifaces = [ | ||
| set_iface_role(module, iface) for iface in ifaces[module.name] | ||
| ] | ||
| ifaces[module.name] = list(updated_ifaces) |
Member
There was a problem hiding this comment.
There is no need making a copy of list?
Suggested change
| updated_ifaces = [ | |
| set_iface_role(module, iface) for iface in ifaces[module.name] | |
| ] | |
| ifaces[module.name] = list(updated_ifaces) | |
| ifaces[module.name] = [ | |
| set_iface_role(module, iface) for iface in ifaces[module.name] | |
| ] |
tapa/steps/floorplan.py
Outdated
|
|
||
| def convert_region_format(region: str) -> str: | ||
| """Convert region format from 'x:y' to 'x_TO_y'.""" | ||
| return region.replace(":", "_TO_") if ":" in region else region |
Member
There was a problem hiding this comment.
Suggested change
| return region.replace(":", "_TO_") if ":" in region else region | |
| return region.replace(":", "_TO_") |
tapa/steps/add_top_passthrough.py
Outdated
|
|
||
| updated_sys_port_pre_assignments = {} | ||
| for port_name, region in sys_port_pre_assignments.items(): | ||
| slot0, slot1 = tuple(region.split(":")) |
Member
There was a problem hiding this comment.
Suggested change
| slot0, slot1 = tuple(region.split(":")) | |
| slot0, slot1 = region.split(":") |
| for port_name, region in sys_port_pre_assignments.items(): | ||
| slot0, slot1 = tuple(region.split(":")) | ||
| if slot0 != slot1: | ||
| new_region = f"{slot0}:{slot0}" |
Member
There was a problem hiding this comment.
Should the second slot0 be slot1?
tapa/steps/meta.py
Outdated
| kwargs["floorplan_path"] = floorplan_file | ||
| kwargs["output"] = str(solution_work_dir / f"{solution_work_dir.name}.xo") | ||
| kwargs["floorplan_path"] = Path(floorplan_file) | ||
| kwargs["output"] = Path(str(solution_work_dir / f"{solution_work_dir.name}.xo")) |
Member
There was a problem hiding this comment.
Suggested change
| kwargs["output"] = Path(str(solution_work_dir / f"{solution_work_dir.name}.xo")) | |
| kwargs["output"] = solution_work_dir / f"{solution_work_dir.name}.xo" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.