-
Notifications
You must be signed in to change notification settings - Fork 329
FIX: Add missing manuals for the tracked input devices components (ISXB-1410) #2152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Add missing manuals for the tracked input devices components (ISXB-1410) #2152
Conversation
0785f70 to
1f41d1e
Compare
ekcoh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this documentation. I think it looks good and I believe it is good that it links further into the script Api documentation that already existed. Also great you added CHANGELOG entry. It makes sense that some feedback is received from XR side as well before landing this.
Pauliusd01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds a bit "fluffy/marketingy" at times but overall fine to me
JonMUnity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some minor suggestions. Let me know if you have any questions!
Packages/com.unity.inputsystem/Documentation~/TrackedInputDevices.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/TrackedInputDevices.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/TrackedInputDevices.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/TrackedInputDevices.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/TrackedInputDevices.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/TrackedInputDevices.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/TrackedInputDevices.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/TrackedInputDevices.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/TrackedInputDevices.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/TrackedInputDevices.md
Outdated
Show resolved
Hide resolved
e37ba52 to
2ce537c
Compare
vrdave-unity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side. You might consider using xref: in the future for the API references from the manual, just in case any of the namespaces or structure moves around your doc references don't break.
Co-authored-by: Chris Massie <[email protected]>
…ces.md Co-authored-by: JonMUnity <[email protected]>
…ces.md Co-authored-by: JonMUnity <[email protected]>
…ces.md Co-authored-by: JonMUnity <[email protected]>
…ces.md Co-authored-by: JonMUnity <[email protected]>
…ces.md Co-authored-by: JonMUnity <[email protected]>
Co-authored-by: JonMUnity <[email protected]>
414e550 to
c837ea2
Compare
Description
This pull request adds two new sections that were priorly missing and causing broken link reports.
Testing status & QA
This is purely a docs change really, nothing's really going to be broken all that much.
Overall Product Risks
Comments to reviewers
None.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: